From: Wolfram Sang <wsa@the-dreams.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Elie Morisse <syniurge@gmail.com>,
Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling
Date: Thu, 30 Apr 2020 16:10:50 +0200 [thread overview]
Message-ID: <20200430141050.GB3355@ninjato> (raw)
In-Reply-To: <20190910134242.GA6620@mwanda>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Tue, Sep 10, 2019 at 04:42:42PM +0300, Dan Carpenter wrote:
> The problem is that we dereference "privdata->pci_dev" when we print
> the error messages in amd_mp2_pci_init():
>
> dev_err(ndev_dev(privdata), "Failed to enable MP2 PCI device\n");
> ^^^^^^^^^^^^^^^^^
>
> Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to for-current, thanks!
Elie, Nehal, Shyam, are you still there to review patches for this
driver?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next parent reply other threads:[~2020-04-30 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAC_JBqofuyRiSmK0mFqVLaY=5k9MYmjGaVmggx2dn_YjN8VOmw@mail.gmail.com>
[not found] ` <20190910134242.GA6620@mwanda>
2020-04-30 14:10 ` Wolfram Sang [this message]
2020-04-30 19:43 ` [PATCH v2] i2c: i2c-amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling Elie Morisse
2020-04-30 20:06 ` Wolfram Sang
2020-05-01 5:10 ` Shah, Nehal-bakulchandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430141050.GB3355@ninjato \
--to=wsa@the-dreams.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=syniurge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox