linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Peter Rosin <peda@axentia.se>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v3 1/4] i2c: mux: pca954x: Refactor pca954x_irq_handler()
Date: Wed, 6 May 2020 19:06:09 +0300	[thread overview]
Message-ID: <20200506160609.GN185537@smile.fi.intel.com> (raw)
In-Reply-To: <5f4f3714-e37c-d2ec-51eb-8cc3c9dd57de@axentia.se>

On Wed, May 06, 2020 at 03:19:29PM +0200, Peter Rosin wrote:
> 
> On 2020-05-06 14:42, Andy Shevchenko wrote:
> > On Sat, Apr 25, 2020 at 02:51:49PM +0300, Andy Shevchenko wrote:
> >> Refactor pca954x_irq_handler() to:
> >>   - use for_each_set_bit() macro
> >>   - use IRQ_RETVAL() macro
> >>
> >> Above change makes code easy to read and understand.
> > 
> > If there is no comments, Wolfram, can you apply this?
> 
> Perhaps that's best, I have had the intention to get to this for a very long
> time and I'm very sorry for delaying. The number of patches for i2c-mux is so
> low that I have not bothered to automate the process, but that also means that
> I have to sort of rediscover how to do it a few times a year. It's simply not
> effective...
> 
> Wolfram, I think it would be better if I just quit my i2c-mux tree and I
> instead review/ack patches that you then take. Would that be ok with you?
> 
> Again, sorry for being a road-block.
> 
> Reviewed-by: Peter Rosin <peda@axentia.se>

Thank you, Peter!

I hope this applies to the entire series?

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2020-05-06 16:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 11:51 [PATCH v3 1/4] i2c: mux: pca954x: Refactor pca954x_irq_handler() Andy Shevchenko
2020-04-25 11:51 ` [PATCH v3 2/4] i2c: mux: pca954x: Make use of device properties Andy Shevchenko
2020-05-06 16:09   ` Peter Rosin
2020-04-25 11:51 ` [PATCH v3 3/4] i2c: mux: pca954x: Move device_remove_file() out of pca954x_cleanup() Andy Shevchenko
2020-05-06 16:10   ` Peter Rosin
2020-04-25 11:51 ` [PATCH v3 4/4] i2c: mux: pca954x: Convert license to SPDX identifier Andy Shevchenko
2020-05-06 16:10   ` Peter Rosin
2020-05-06 12:42 ` [PATCH v3 1/4] i2c: mux: pca954x: Refactor pca954x_irq_handler() Andy Shevchenko
2020-05-06 13:19   ` Peter Rosin
2020-05-06 15:45     ` Wolfram Sang
2020-05-06 16:06     ` Andy Shevchenko [this message]
2020-05-06 16:09       ` Peter Rosin
2020-05-11 19:26       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506160609.GN185537@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).