From: Wolfram Sang <wsa@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/4] i2c: pxa: consolidate i2c_pxa_*xfer() implementations
Date: Mon, 11 May 2020 21:59:15 +0200 [thread overview]
Message-ID: <20200511195915.GC8724@ninjato> (raw)
In-Reply-To: <E1jWGMa-0000N1-L6@rmk-PC.armlinux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Wed, May 06, 2020 at 10:29:12AM +0100, Russell King wrote:
> Most of i2c_pxa_pio_xfer() and i2c_pxa_xfer() are identical; the only
> differences are that i2c_pxa_pio_xfer() may reset the bus, and they
> use different underlying transfer functions. The retry loop is the
> same. Consolidate these two functions.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Fails to build here:
In file included from ./include/linux/device.h:15,
from ./include/linux/acpi.h:15,
from ./include/linux/i2c.h:13,
from drivers/i2c/busses/i2c-pxa.c:23:
drivers/i2c/busses/i2c-pxa.c: In function ‘i2c_pxa_internal_xfer’:
drivers/i2c/busses/i2c-pxa.c:1118:13: error: ‘adap’ undeclared (first use in this function); did you mean ‘vmap’?
dev_dbg(&adap->dev, "Retrying transmission\n");
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-11 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 9:28 [PATCH 0/4] Further i2c-pxa cleanups Russell King - ARM Linux admin
2020-05-06 9:29 ` [PATCH 1/4] i2c: pxa: consolidate i2c_pxa_*xfer() implementations Russell King
2020-05-11 19:59 ` Wolfram Sang [this message]
2020-05-11 20:20 ` Russell King - ARM Linux admin
2020-05-06 9:29 ` [PATCH 2/4] i2c: pxa: avoid complaints with non-responsive slaves Russell King
2020-05-06 9:29 ` [PATCH 3/4] i2c: pxa: ensure timeout messages are unique Russell King
2020-05-06 9:29 ` [PATCH 4/4] i2c: pxa: remove some unnecessary debug Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511195915.GC8724@ninjato \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).