From: Wolfram Sang <wsa@the-dreams.de>
To: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
Cc: Thor Thayer <thor.thayer@linux.intel.com>,
linux-i2c@vger.kernel.org, tomonori.sakita@sord.co.jp
Subject: Re: [PATCH 1/2] i2c: altera: Fix race between xfer_msg and isr thread
Date: Tue, 12 May 2020 15:00:30 +0200 [thread overview]
Message-ID: <20200512130029.GB13516@ninjato> (raw)
In-Reply-To: <20200508.221248.1850264063769224908.atsushi.nemoto@sord.co.jp>
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
On Fri, May 08, 2020 at 10:12:48PM +0900, Atsushi Nemoto wrote:
> Use a mutex to protect access to idev->msg_len, idev->buf, etc. which
> are modified by both altr_i2c_xfer_msg() and altr_i2c_isr().
>
> Signed-off-by: Atsushi Nemoto <atsushi.nemoto@sord.co.jp>
> Acked-by: Thor Thayer <thor.thayer@linux.intel.com>
Applied to for-current, thanks! I added the following snipplet to the
commit message:
This is the minimal fix for easy backporting. A cleanup to remove the
spinlock will be added later.
I will give Thor some more days to review patch 2/2. It looks good to
me, though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-05-12 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 13:12 [PATCH 1/2] i2c: altera: Fix race between xfer_msg and isr thread Atsushi Nemoto
2020-05-12 13:00 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512130029.GB13516@ninjato \
--to=wsa@the-dreams.de \
--cc=atsushi.nemoto@sord.co.jp \
--cc=linux-i2c@vger.kernel.org \
--cc=thor.thayer@linux.intel.com \
--cc=tomonori.sakita@sord.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox