* [PATCH 0/1] mfd: convert to use new I2C API
@ 2020-03-26 21:10 Wolfram Sang
2020-03-26 21:10 ` [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device() Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:10 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, linux-kernel
We are deprecating calls which return NULL in favor of new variants which
return an ERR_PTR. Only build tested.
Wolfram Sang (1):
mfd: htc-i2cpld: convert to use i2c_new_client_device()
drivers/mfd/htc-i2cpld.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device()
2020-03-26 21:10 [PATCH 0/1] mfd: convert to use new I2C API Wolfram Sang
@ 2020-03-26 21:10 ` Wolfram Sang
2020-04-15 11:04 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:10 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move away from the deprecated API and return the shiny new ERRPTR where
useful.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mfd/htc-i2cpld.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index 8ad6768bd7a2..247f9849e54a 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -355,12 +355,12 @@ static int htcpld_register_chip_i2c(
info.platform_data = chip;
/* Add the I2C device. This calls the probe() function. */
- client = i2c_new_device(adapter, &info);
- if (!client) {
+ client = i2c_new_client_device(adapter, &info);
+ if (IS_ERR(client)) {
/* I2C device registration failed, contineu with the next */
dev_warn(dev, "Unable to add I2C device for 0x%x\n",
plat_chip_data->addr);
- return -ENODEV;
+ return PTR_ERR(client);
}
i2c_set_clientdata(client, chip);
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device()
2020-03-26 21:10 ` [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device() Wolfram Sang
@ 2020-04-15 11:04 ` Lee Jones
2020-05-12 16:26 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2020-04-15 11:04 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Thu, 26 Mar 2020, Wolfram Sang wrote:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/mfd/htc-i2cpld.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device()
2020-04-15 11:04 ` Lee Jones
@ 2020-05-12 16:26 ` Wolfram Sang
2020-05-13 7:56 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2020-05-12 16:26 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Wed, Apr 15, 2020 at 12:04:42PM +0100, Lee Jones wrote:
> On Thu, 26 Mar 2020, Wolfram Sang wrote:
>
> > Move away from the deprecated API and return the shiny new ERRPTR where
> > useful.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > ---
> > drivers/mfd/htc-i2cpld.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Applied, thanks.
Thanks! I don't see it in -next, though?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device()
2020-05-12 16:26 ` Wolfram Sang
@ 2020-05-13 7:56 ` Lee Jones
2020-05-13 8:24 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2020-05-13 7:56 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Tue, 12 May 2020, Wolfram Sang wrote:
> On Wed, Apr 15, 2020 at 12:04:42PM +0100, Lee Jones wrote:
> > On Thu, 26 Mar 2020, Wolfram Sang wrote:
> >
> > > Move away from the deprecated API and return the shiny new ERRPTR where
> > > useful.
> > >
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > ---
> > > drivers/mfd/htc-i2cpld.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Applied, thanks.
>
> Thanks! I don't see it in -next, though?
Haven't pushed for a while. Should be there when -next is rebuilt.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-13 8:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-26 21:10 [PATCH 0/1] mfd: convert to use new I2C API Wolfram Sang
2020-03-26 21:10 ` [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device() Wolfram Sang
2020-04-15 11:04 ` Lee Jones
2020-05-12 16:26 ` Wolfram Sang
2020-05-13 7:56 ` Lee Jones
2020-05-13 8:24 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).