* [PATCH 1/2] i2c: slave-eeprom: skip useless initialization
@ 2020-05-25 9:59 Wolfram Sang
2020-05-25 9:59 ` [PATCH 2/2] i2c: slave-eeprom: update documentation to recent changes Wolfram Sang
2020-05-28 16:06 ` [PATCH 1/2] i2c: slave-eeprom: skip useless initialization Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-05-25 9:59 UTC (permalink / raw)
To: linux-i2c; +Cc: Björn Ardö, Wolfram Sang
We have a kzalloced struct, no need to init to 0.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/i2c-slave-eeprom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c
index 787fdb7f332f..6684852818ac 100644
--- a/drivers/i2c/i2c-slave-eeprom.c
+++ b/drivers/i2c/i2c-slave-eeprom.c
@@ -152,7 +152,6 @@ static int i2c_slave_eeprom_probe(struct i2c_client *client, const struct i2c_de
if (!eeprom)
return -ENOMEM;
- eeprom->idx_write_cnt = 0;
eeprom->num_address_bytes = flag_addr16 ? 2 : 1;
eeprom->address_mask = size - 1;
eeprom->read_only = FIELD_GET(I2C_SLAVE_FLAG_RO, id->driver_data);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] i2c: slave-eeprom: update documentation to recent changes
2020-05-25 9:59 [PATCH 1/2] i2c: slave-eeprom: skip useless initialization Wolfram Sang
@ 2020-05-25 9:59 ` Wolfram Sang
2020-05-28 16:06 ` Wolfram Sang
2020-05-28 16:06 ` [PATCH 1/2] i2c: slave-eeprom: skip useless initialization Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2020-05-25 9:59 UTC (permalink / raw)
To: linux-i2c; +Cc: Björn Ardö, Wolfram Sang
Support for 16-bit addresses has been added, so remove it from the todo
list. Also, in the introductory sentence, may clear we talk about "slave
IP cores" to make reading easier.
Fixes: 82d514815441 ("i2c-eeprom_slave: Add support for more eeprom models")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/i2c-slave-eeprom.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c
index 6684852818ac..593f2fd39d17 100644
--- a/drivers/i2c/i2c-slave-eeprom.c
+++ b/drivers/i2c/i2c-slave-eeprom.c
@@ -5,10 +5,9 @@
* Copyright (C) 2014 by Wolfram Sang, Sang Engineering <wsa@sang-engineering.com>
* Copyright (C) 2014 by Renesas Electronics Corporation
*
- * Because most IP blocks can only detect one I2C slave address anyhow, this
- * driver does not support simulating EEPROM types which take more than one
- * address. It is prepared to simulate bigger EEPROMs with an internal 16 bit
- * pointer, yet implementation is deferred until the need actually arises.
+ * Because most slave IP cores can only detect one I2C slave address anyhow,
+ * this driver does not support simulating EEPROM types which take more than
+ * one address.
*/
/*
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] i2c: slave-eeprom: update documentation to recent changes
2020-05-25 9:59 ` [PATCH 2/2] i2c: slave-eeprom: update documentation to recent changes Wolfram Sang
@ 2020-05-28 16:06 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-05-28 16:06 UTC (permalink / raw)
To: linux-i2c; +Cc: Björn Ardö
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
On Mon, May 25, 2020 at 11:59:34AM +0200, Wolfram Sang wrote:
> Support for 16-bit addresses has been added, so remove it from the todo
> list. Also, in the introductory sentence, may clear we talk about "slave
> IP cores" to make reading easier.
>
> Fixes: 82d514815441 ("i2c-eeprom_slave: Add support for more eeprom models")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c: slave-eeprom: skip useless initialization
2020-05-25 9:59 [PATCH 1/2] i2c: slave-eeprom: skip useless initialization Wolfram Sang
2020-05-25 9:59 ` [PATCH 2/2] i2c: slave-eeprom: update documentation to recent changes Wolfram Sang
@ 2020-05-28 16:06 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-05-28 16:06 UTC (permalink / raw)
To: linux-i2c; +Cc: Björn Ardö
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
On Mon, May 25, 2020 at 11:59:33AM +0200, Wolfram Sang wrote:
> We have a kzalloced struct, no need to init to 0.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-28 16:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-25 9:59 [PATCH 1/2] i2c: slave-eeprom: skip useless initialization Wolfram Sang
2020-05-25 9:59 ` [PATCH 2/2] i2c: slave-eeprom: update documentation to recent changes Wolfram Sang
2020-05-28 16:06 ` Wolfram Sang
2020-05-28 16:06 ` [PATCH 1/2] i2c: slave-eeprom: skip useless initialization Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).