From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: sh_mobile: Fix compilation warning
Date: Fri, 29 May 2020 14:12:46 +0200 [thread overview]
Message-ID: <20200529121245.GA20272@ninjato> (raw)
In-Reply-To: <f526f90ea62741716de2ecfa310ba22d8cf1d3c2.1557377015.git.viresh.kumar@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Thu, May 09, 2019 at 10:13:46AM +0530, Viresh Kumar wrote:
> This currently generates a warning:
>
> drivers/i2c/busses/i2c-sh_mobile.c: In function 'sh_mobile_i2c_isr':
> drivers/i2c/busses/i2c-sh_mobile.c:399:26: warning: 'data' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Though the code looks okay and shouldn't ever use the variable
> uninitialized.
>
> Fix the warning by moving the code around and getting rid of 'data'.
>
> Compile tested only.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Tested on a Renesas Lager board (R-Car H2). Dumping register sets
produces identical results.
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
And code is actually cleaner now.
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-29 12:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 4:43 [PATCH] i2c: sh_mobile: Fix compilation warning Viresh Kumar
2020-05-29 12:12 ` Wolfram Sang [this message]
2020-06-01 3:59 ` Viresh Kumar
2020-06-02 6:50 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529121245.GA20272@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).