From: Jean Delvare <jdelvare@suse.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: <linux-i2c@vger.kernel.org>, Wolfram Sang <wsa@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors
Date: Thu, 11 Jun 2020 12:02:18 +0200 [thread overview]
Message-ID: <20200611120218.7324a7a7@endymion> (raw)
In-Reply-To: <20200610141142.2598882-1-jarkko.nikula@linux.intel.com>
Hi Jarrko,
On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote:
> Modules with multiple authors should use multiple MODULE_AUTHOR()
> statements. Split the i2c modules with multiple authors to use multiple
> MODULE_AUTHOR() statements.
Out of curiosity, is this documented anywhere, and what is the
rationale? FWIW, this change slightly increases the binary size of the
modules.
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> I decided to change all these modules in one patch. I can split if needed.
> ---
> drivers/i2c/algos/i2c-algo-pca.c | 4 ++--
> drivers/i2c/busses/i2c-ali1535.c | 8 ++++----
> drivers/i2c/busses/i2c-ali15x3.c | 6 +++---
> drivers/i2c/busses/i2c-emev2.c | 3 ++-
> drivers/i2c/busses/i2c-i801.c | 3 ++-
> drivers/i2c/busses/i2c-piix4.c | 4 ++--
> drivers/i2c/busses/i2c-pnx.c | 3 ++-
> drivers/i2c/busses/i2c-sh_mobile.c | 3 ++-
> drivers/i2c/busses/i2c-sibyte.c | 3 ++-
> drivers/i2c/i2c-dev.c | 4 ++--
> 10 files changed, 23 insertions(+), 18 deletions(-)
> (...)
If that's the way we are going then the patch looks good.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
However I see multi-author MODULE_AUTHOR() statements left in
i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c, any reason why these are
not included in your patch?
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-06-11 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 14:11 [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors Jarkko Nikula
2020-06-11 10:02 ` Jean Delvare [this message]
2020-06-11 10:23 ` Jarkko Nikula
2020-06-11 13:11 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611120218.7324a7a7@endymion \
--to=jdelvare@suse.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=vz@mleia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).