From: Jean Delvare <jdelvare@suse.de>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors
Date: Thu, 11 Jun 2020 15:11:10 +0200 [thread overview]
Message-ID: <20200611151110.7774a208@endymion> (raw)
In-Reply-To: <1bea211b-6047-a8f1-08f1-3ef82fd04211@linux.intel.com>
On Thu, 11 Jun 2020 13:23:24 +0300, Jarkko Nikula wrote:
> Hi
>
> On 6/11/20 1:02 PM, Jean Delvare wrote:
> > Hi Jarrko,
> >
> > On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote:
> >> Modules with multiple authors should use multiple MODULE_AUTHOR()
> >> statements. Split the i2c modules with multiple authors to use multiple
> >> MODULE_AUTHOR() statements.
> >
> > Out of curiosity, is this documented anywhere, and what is the
> > rationale? FWIW, this change slightly increases the binary size of the
> > modules.
> >
> I randomly spotted it in i2c-i801.c and started wonder since typically
> I've seen multiple MODULE_AUTHOR() lines. Only mention about it I
> quickly found was in include/linux/module.h:
>
> /*
> * Author(s), use "Name <email>" or just "Name", for multiple
> * authors use multiple MODULE_AUTHOR() statements/lines.
> */
> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
OK, that's authoritative enough for sure. Go ahead! :-)
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-06-11 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 14:11 [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors Jarkko Nikula
2020-06-11 10:02 ` Jean Delvare
2020-06-11 10:23 ` Jarkko Nikula
2020-06-11 13:11 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611151110.7774a208@endymion \
--to=jdelvare@suse.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=slemieux.tyco@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=vz@mleia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).