[PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors

[PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors

[Jarkko Nikula]

Modules with multiple authors should use multiple MODULE_AUTHOR()
statements. Split the i2c modules with multiple authors to use multiple
MODULE_AUTHOR() statements.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
I decided to change all these modules in one patch. I can split if needed.
---
 drivers/i2c/algos/i2c-algo-pca.c   | 4 ++--
 drivers/i2c/busses/i2c-ali1535.c   | 8 ++++----
 drivers/i2c/busses/i2c-ali15x3.c   | 6 +++---
 drivers/i2c/busses/i2c-emev2.c     | 3 ++-
 drivers/i2c/busses/i2c-i801.c      | 3 ++-
 drivers/i2c/busses/i2c-piix4.c     | 4 ++--
 drivers/i2c/busses/i2c-pnx.c       | 3 ++-
 drivers/i2c/busses/i2c-sh_mobile.c | 3 ++-
 drivers/i2c/busses/i2c-sibyte.c    | 3 ++-
 drivers/i2c/i2c-dev.c              | 4 ++--
 10 files changed, 23 insertions(+), 18 deletions(-)

diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c
index 7f10312d1b88..8620963e442c 100644
--- a/drivers/i2c/algos/i2c-algo-pca.c
+++ b/drivers/i2c/algos/i2c-algo-pca.c
@@ -541,8 +541,8 @@ int i2c_pca_add_numbered_bus(struct i2c_adapter *adap)
 }
 EXPORT_SYMBOL(i2c_pca_add_numbered_bus);
 
-MODULE_AUTHOR("Ian Campbell <icampbell@arcom.com>, "
-	"Wolfram Sang <kernel@pengutronix.de>");
+MODULE_AUTHOR("Ian Campbell <icampbell@arcom.com>");
+MODULE_AUTHOR("Wolfram Sang <kernel@pengutronix.de>");
 MODULE_DESCRIPTION("I2C-Bus PCA9564/PCA9665 algorithm");
 MODULE_LICENSE("GPL");
 
diff --git a/drivers/i2c/busses/i2c-ali1535.c b/drivers/i2c/busses/i2c-ali1535.c
index a43deea390f5..fb93152845f4 100644
--- a/drivers/i2c/busses/i2c-ali1535.c
+++ b/drivers/i2c/busses/i2c-ali1535.c
@@ -519,9 +519,9 @@ static struct pci_driver ali1535_driver = {
 
 module_pci_driver(ali1535_driver);
 
-MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>, "
-	      "Philip Edelbrock <phil@netroedge.com>, "
-	      "Mark D. Studebaker <mdsxyz123@yahoo.com> "
-	      "and Dan Eaton <dan.eaton@rocketlogix.com>");
+MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>");
+MODULE_AUTHOR("Philip Edelbrock <phil@netroedge.com>");
+MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>");
+MODULE_AUTHOR("Dan Eaton <dan.eaton@rocketlogix.com>");
 MODULE_DESCRIPTION("ALI1535 SMBus driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/busses/i2c-ali15x3.c b/drivers/i2c/busses/i2c-ali15x3.c
index 02185a1cfa77..cc58feacd082 100644
--- a/drivers/i2c/busses/i2c-ali15x3.c
+++ b/drivers/i2c/busses/i2c-ali15x3.c
@@ -502,8 +502,8 @@ static struct pci_driver ali15x3_driver = {
 
 module_pci_driver(ali15x3_driver);
 
-MODULE_AUTHOR ("Frodo Looijaard <frodol@dds.nl>, "
-		"Philip Edelbrock <phil@netroedge.com>, "
-		"and Mark D. Studebaker <mdsxyz123@yahoo.com>");
+MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>");
+MODULE_AUTHOR("Philip Edelbrock <phil@netroedge.com>");
+MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>");
 MODULE_DESCRIPTION("ALI15X3 SMBus driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c
index 1a319352e51b..a08554c1a570 100644
--- a/drivers/i2c/busses/i2c-emev2.c
+++ b/drivers/i2c/busses/i2c-emev2.c
@@ -442,6 +442,7 @@ static struct platform_driver em_i2c_driver = {
 module_platform_driver(em_i2c_driver);
 
 MODULE_DESCRIPTION("EMEV2 I2C bus driver");
-MODULE_AUTHOR("Ian Molton and Wolfram Sang <wsa@sang-engineering.com>");
+MODULE_AUTHOR("Ian Molton");
+MODULE_AUTHOR("Wolfram Sang <wsa@sang-engineering.com>");
 MODULE_LICENSE("GPL v2");
 MODULE_DEVICE_TABLE(of, em_i2c_ids);
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index fea644921a76..1fc7ae77753d 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1986,7 +1986,8 @@ static void __exit i2c_i801_exit(void)
 	pci_unregister_driver(&i801_driver);
 }
 
-MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>, Jean Delvare <jdelvare@suse.de>");
+MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>");
+MODULE_AUTHOR("Jean Delvare <jdelvare@suse.de>");
 MODULE_DESCRIPTION("I801 SMBus driver");
 MODULE_LICENSE("GPL");
 
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 69740a4ff1db..8c1b31ed0c42 100644
--- a/drivers/i2c/busses/i2c-piix4.c
+++ b/drivers/i2c/busses/i2c-piix4.c
@@ -1032,7 +1032,7 @@ static struct pci_driver piix4_driver = {
 
 module_pci_driver(piix4_driver);
 
-MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl> and "
-		"Philip Edelbrock <phil@netroedge.com>");
+MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>");
+MODULE_AUTHOR("Philip Edelbrock <phil@netroedge.com>");
 MODULE_DESCRIPTION("PIIX4 SMBus driver");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/busses/i2c-pnx.c b/drivers/i2c/busses/i2c-pnx.c
index 5d7207c10f1d..8c4ec7f13f5a 100644
--- a/drivers/i2c/busses/i2c-pnx.c
+++ b/drivers/i2c/busses/i2c-pnx.c
@@ -781,7 +781,8 @@ static void __exit i2c_adap_pnx_exit(void)
 	platform_driver_unregister(&i2c_pnx_driver);
 }
 
-MODULE_AUTHOR("Vitaly Wool, Dennis Kovalev <source@mvista.com>");
+MODULE_AUTHOR("Vitaly Wool");
+MODULE_AUTHOR("Dennis Kovalev <source@mvista.com>");
 MODULE_DESCRIPTION("I2C driver for Philips IP3204-based I2C busses");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:pnx-i2c");
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 2cca1b21e26e..cab725559999 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -932,6 +932,7 @@ static void __exit sh_mobile_i2c_adap_exit(void)
 module_exit(sh_mobile_i2c_adap_exit);
 
 MODULE_DESCRIPTION("SuperH Mobile I2C Bus Controller driver");
-MODULE_AUTHOR("Magnus Damm and Wolfram Sang");
+MODULE_AUTHOR("Magnus Damm");
+MODULE_AUTHOR("Wolfram Sang");
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:i2c-sh_mobile");
diff --git a/drivers/i2c/busses/i2c-sibyte.c b/drivers/i2c/busses/i2c-sibyte.c
index 9dcea2ba7168..8f71f01cb169 100644
--- a/drivers/i2c/busses/i2c-sibyte.c
+++ b/drivers/i2c/busses/i2c-sibyte.c
@@ -180,6 +180,7 @@ static void __exit i2c_sibyte_exit(void)
 module_init(i2c_sibyte_init);
 module_exit(i2c_sibyte_exit);
 
-MODULE_AUTHOR("Kip Walker (Broadcom Corp.), Steven J. Hill <sjhill@realitydiluted.com>");
+MODULE_AUTHOR("Kip Walker (Broadcom Corp.)");
+MODULE_AUTHOR("Steven J. Hill <sjhill@realitydiluted.com>");
 MODULE_DESCRIPTION("SMBus adapter routines for SiByte boards");
 MODULE_LICENSE("GPL");
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index da020acc9bbd..6ceb11cc4be1 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -761,8 +761,8 @@ static void __exit i2c_dev_exit(void)
 	unregister_chrdev_region(MKDEV(I2C_MAJOR, 0), I2C_MINORS);
 }
 
-MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl> and "
-		"Simon G. Vogl <simon@tk.uni-linz.ac.at>");
+MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>");
+MODULE_AUTHOR("Simon G. Vogl <simon@tk.uni-linz.ac.at>");
 MODULE_DESCRIPTION("I2C /dev entries driver");
 MODULE_LICENSE("GPL");
 
-- 
2.26.2

Re: [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors

[Jean Delvare]

Hi Jarrko,

On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote:
> Modules with multiple authors should use multiple MODULE_AUTHOR()
> statements. Split the i2c modules with multiple authors to use multiple
> MODULE_AUTHOR() statements.

Out of curiosity, is this documented anywhere, and what is the
rationale? FWIW, this change slightly increases the binary size of the
modules.

> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> I decided to change all these modules in one patch. I can split if needed.
> ---
>  drivers/i2c/algos/i2c-algo-pca.c   | 4 ++--
>  drivers/i2c/busses/i2c-ali1535.c   | 8 ++++----
>  drivers/i2c/busses/i2c-ali15x3.c   | 6 +++---
>  drivers/i2c/busses/i2c-emev2.c     | 3 ++-
>  drivers/i2c/busses/i2c-i801.c      | 3 ++-
>  drivers/i2c/busses/i2c-piix4.c     | 4 ++--
>  drivers/i2c/busses/i2c-pnx.c       | 3 ++-
>  drivers/i2c/busses/i2c-sh_mobile.c | 3 ++-
>  drivers/i2c/busses/i2c-sibyte.c    | 3 ++-
>  drivers/i2c/i2c-dev.c              | 4 ++--
>  10 files changed, 23 insertions(+), 18 deletions(-)
> (...)

If that's the way we are going then the patch looks good.

Reviewed-by: Jean Delvare <jdelvare@suse.de>

However I see multi-author MODULE_AUTHOR() statements left in
i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c, any reason why these are
not included in your patch?

-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors

[Jarkko Nikula]

Hi

On 6/11/20 1:02 PM, Jean Delvare wrote:
> Hi Jarrko,
> 
> On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote:
>> Modules with multiple authors should use multiple MODULE_AUTHOR()
>> statements. Split the i2c modules with multiple authors to use multiple
>> MODULE_AUTHOR() statements.
> 
> Out of curiosity, is this documented anywhere, and what is the
> rationale? FWIW, this change slightly increases the binary size of the
> modules.
> 
I randomly spotted it in i2c-i801.c and started wonder since typically 
I've seen multiple MODULE_AUTHOR() lines. Only mention about it I 
quickly found was in include/linux/module.h:

/*
  * Author(s), use "Name <email>" or just "Name", for multiple
  * authors use multiple MODULE_AUTHOR() statements/lines.
  */
#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

> However I see multi-author MODULE_AUTHOR() statements left in
> i2c-nomadik.c, i2c-sirf.c and i2c-viapro.c, any reason why these are
> not included in your patch?
> 
My blind eye :-)

Will include these to 2nd version.

Jarkko

Re: [PATCH] i2c: Use separate MODULE_AUTHOR() statements for multiple authors

[Jean Delvare]

On Thu, 11 Jun 2020 13:23:24 +0300, Jarkko Nikula wrote:
> Hi
> 
> On 6/11/20 1:02 PM, Jean Delvare wrote:
> > Hi Jarrko,
> > 
> > On Wed, 10 Jun 2020 17:11:42 +0300, Jarkko Nikula wrote:  
> >> Modules with multiple authors should use multiple MODULE_AUTHOR()
> >> statements. Split the i2c modules with multiple authors to use multiple
> >> MODULE_AUTHOR() statements.  
> > 
> > Out of curiosity, is this documented anywhere, and what is the
> > rationale? FWIW, this change slightly increases the binary size of the
> > modules.
> >   
> I randomly spotted it in i2c-i801.c and started wonder since typically 
> I've seen multiple MODULE_AUTHOR() lines. Only mention about it I 
> quickly found was in include/linux/module.h:
> 
> /*
>   * Author(s), use "Name <email>" or just "Name", for multiple
>   * authors use multiple MODULE_AUTHOR() statements/lines.
>   */
> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)

OK, that's authoritative enough for sure. Go ahead! :-)

-- 
Jean Delvare
SUSE L3 Support