From: Wolfram Sang <wsa@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-i2c@vger.kernel.org, Michal Simek <michal.simek@xilinx.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCH 5/5] i2c: xiic: Only ever transfer single message
Date: Sat, 13 Jun 2020 21:42:20 +0200 [thread overview]
Message-ID: <20200613194220.GB6289@kunai> (raw)
In-Reply-To: <b79cdce5-9eff-411b-e2aa-30365a6bbc3d@denx.de>
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
> >> Transferring multiple messages via XIIC suffers from strange interaction
> >> between the interrupt status/enable register flags. These flags are being
> >> reused in the hardware to indicate different things for read and write
> >> transfer, and doing multiple transactions becomes horribly complex. Just
> >> send a single transaction and reload the controller with another message
> >> once the transaction is done in the interrupt handler thread.
> >
> > Do we still get a repeated start between messages of a transfer? Or will
> > it be a STOP/START combination?
>
> Repeated start.
Good. That was my high level question. I'll leave the rest of the review
then for Michal.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-06-13 19:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 15:07 [PATCH 1/5] i2c: xiic: Fix broken locking on tx_msg Marek Vasut
2020-06-13 15:07 ` [PATCH 2/5] i2c: xiic: Drop broken interrupt handler Marek Vasut
2020-06-17 12:25 ` Shubhrajyoti Datta
2020-06-17 12:31 ` Marek Vasut
2020-06-26 12:13 ` Raviteja Narayanam
2020-06-28 23:41 ` Marek Vasut
2020-06-29 12:52 ` Raviteja Narayanam
2020-06-29 21:50 ` Marek Vasut
2020-07-08 15:23 ` Raviteja Narayanam
2020-08-19 17:42 ` Marek Vasut
2020-08-24 8:27 ` Raviteja Narayanam
2020-08-24 11:58 ` Marek Vasut
2020-08-25 9:44 ` Raviteja Narayanam
2020-08-25 20:50 ` Marek Vasut
2020-09-07 8:51 ` Raviteja Narayanam
2020-09-08 14:04 ` Marek Vasut
2020-09-11 10:28 ` Michal Simek
2020-06-13 15:07 ` [PATCH 3/5] i2c: xiic: Defer xiic_wakeup() and __xiic_start_xfer() in xiic_process() Marek Vasut
2020-06-26 12:13 ` Raviteja Narayanam
2020-07-08 15:23 ` Raviteja Narayanam
2020-06-13 15:07 ` [PATCH 4/5] i2c: xiic: Switch from waitqueue to completion Marek Vasut
2020-06-26 12:13 ` Raviteja Narayanam
2020-06-28 23:41 ` Marek Vasut
2020-06-29 12:53 ` Raviteja Narayanam
2020-06-29 21:52 ` Marek Vasut
2020-06-13 15:07 ` [PATCH 5/5] i2c: xiic: Only ever transfer single message Marek Vasut
2020-06-13 19:33 ` Wolfram Sang
2020-06-13 19:37 ` Marek Vasut
2020-06-13 19:42 ` Wolfram Sang [this message]
2020-07-13 8:37 ` Michal Simek
2020-06-26 12:14 ` Raviteja Narayanam
2020-06-26 12:11 ` [PATCH 1/5] i2c: xiic: Fix broken locking on tx_msg Raviteja Narayanam
2020-06-28 23:18 ` Marek Vasut
2020-06-29 12:52 ` Raviteja Narayanam
2020-07-08 15:23 ` Raviteja Narayanam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200613194220.GB6289@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=marex@denx.de \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).