From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B742BC433DF for ; Mon, 15 Jun 2020 06:50:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 865962068E for ; Mon, 15 Jun 2020 06:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592203806; bh=MVFgK3yeWPZ+i6DSCvto+y8Jl33RI6uJ7L+1TA3EfUY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rSrN3z8bBUTs+m8NafrRvWY5mPoAUO59LSv/D9BCjK5Mc60FrcnsW1hXuIFU8nvdj LQVkuzLxEfkn1AjCwqosNwW1N07y/T7uz0MJj3+vezwIxXMyRb0VBg+2Uc62yMRKZS xU0LZYpSUtISlZqoeIqC8Fr3BzmWRTZPrICwproY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728538AbgFOGuG (ORCPT ); Mon, 15 Jun 2020 02:50:06 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:46555 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728486AbgFOGuF (ORCPT ); Mon, 15 Jun 2020 02:50:05 -0400 Received: by mail-ed1-f67.google.com with SMTP id m21so10634074eds.13; Sun, 14 Jun 2020 23:50:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vKJpOmM9DH/2UhmBwmYAEHUF6KlZyjtAnBjFXv+lhg8=; b=dmMil4HxQdMjiwap0oj02lDOttOFmdYfxNdo6qimXZEJey9PaW4lt7dchzUKNZnNm+ z7mwgequY2fF4TjR7H2qFZ9i+DAnwm9ZNf8JsTq0rkLJlx5C9r/F5mHA84fm0K9uvp4Z QR5GzFU7Nw6DL9Y1P/u9oNz4pHRzEnPdICuO+Y2/Zx3LDejSbrmDw6h9IQAeggeSf7Xo mtyu0FSpwJ1C8AIFyFA+mfNkOj4yEZC9DzYvqBF1pfUpEQhjH9aucjbxM/b8W6cZTIU2 dun0FIbro9YNICwlnKzNb6/A7/hkDP+0W3nNVp0HNligaZKrxijhIq/vOavAHlo5DHlb e/1A== X-Gm-Message-State: AOAM531A240ThJkVfk3YXzN+m+IJ6UCL+iSVgoU5Ih1vEWbwVsGYYBjg J26T67fqZ5C536bed+1FEyI= X-Google-Smtp-Source: ABdhPJxD5/50BDSpXBl1ldUdAkvys7Ip8mS9MB2im+cSgFQh8Vj0lNC/SZV7F9XvmjbinVMlk37bfQ== X-Received: by 2002:aa7:d388:: with SMTP id x8mr23084385edq.380.1592203803200; Sun, 14 Jun 2020 23:50:03 -0700 (PDT) Received: from kozik-lap ([194.230.155.184]) by smtp.googlemail.com with ESMTPSA id q14sm7801859edj.47.2020.06.14.23.50.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 14 Jun 2020 23:50:02 -0700 (PDT) Date: Mon, 15 Jun 2020 08:50:00 +0200 From: Krzysztof Kozlowski To: Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Wolfram Sang , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Marc Kleine-Budde , Oleksij Rempel , stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] i2c: imx: Fix PM runtime inbalance in probe error path Message-ID: <20200615065000.GA7728@kozik-lap> References: <1592130544-19759-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1592130544-19759-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Sun, Jun 14, 2020 at 12:29:03PM +0200, Krzysztof Kozlowski wrote: > When pm_runtime_get_sync() fails in probe(), the error path should not > call pm_runtime_put_noidle(). This would lead to inbalance in > usage_count. > > Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance") > Cc: > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch This patch is not correct because the runtime usage counter is increased always, also on failures. It can be dropped. Best regards, Krzysztof