* [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH
@ 2020-06-18 13:42 Jarkko Nikula
2020-06-18 13:42 ` [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H Jarkko Nikula
2020-07-07 13:33 ` [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jean Delvare
0 siblings, 2 replies; 6+ messages in thread
From: Jarkko Nikula @ 2020-06-18 13:42 UTC (permalink / raw)
To: linux-i2c; +Cc: Jean Delvare, Wolfram Sang, Mika Westerberg, Jarkko Nikula
From: Mika Westerberg <mika.westerberg@linux.intel.com>
Add support for SMBus controller on Intel Emmitsburg PCH. This is the
same IP as used in Cannon Lake and derivatives.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
Documentation/i2c/busses/i2c-i801.rst | 1 +
drivers/i2c/busses/Kconfig | 1 +
drivers/i2c/busses/i2c-i801.c | 4 ++++
3 files changed, 6 insertions(+)
diff --git a/Documentation/i2c/busses/i2c-i801.rst b/Documentation/i2c/busses/i2c-i801.rst
index b83da0e94184..faf32330c335 100644
--- a/Documentation/i2c/busses/i2c-i801.rst
+++ b/Documentation/i2c/busses/i2c-i801.rst
@@ -43,6 +43,7 @@ Supported adapters:
* Intel Elkhart Lake (PCH)
* Intel Tiger Lake (PCH)
* Intel Jasper Lake (SOC)
+ * Intel Emmitsburg (PCH)
Datasheets: Publicly available at the Intel website
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 735bf31a3fdf..085ca9b009ed 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -146,6 +146,7 @@ config I2C_I801
Elkhart Lake (PCH)
Tiger Lake (PCH)
Jasper Lake (SOC)
+ Emmitsburg (PCH)
This driver can also be built as a module. If so, the module
will be called i2c-i801.
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index fea644921a76..7797ef1d25d9 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -54,6 +54,7 @@
* Sunrise Point-H (PCH) 0xa123 32 hard yes yes yes
* Sunrise Point-LP (PCH) 0x9d23 32 hard yes yes yes
* DNV (SOC) 0x19df 32 hard yes yes yes
+ * Emmitsburg (PCH) 0x1bc9 32 hard yes yes yes
* Broxton (SOC) 0x5ad4 32 hard yes yes yes
* Lewisburg (PCH) 0xa1a3 32 hard yes yes yes
* Lewisburg Supersku (PCH) 0xa223 32 hard yes yes yes
@@ -207,6 +208,7 @@
#define PCI_DEVICE_ID_INTEL_BAYTRAIL_SMBUS 0x0f12
#define PCI_DEVICE_ID_INTEL_CDF_SMBUS 0x18df
#define PCI_DEVICE_ID_INTEL_DNV_SMBUS 0x19df
+#define PCI_DEVICE_ID_INTEL_EBG_SMBUS 0x1bc9
#define PCI_DEVICE_ID_INTEL_COUGARPOINT_SMBUS 0x1c22
#define PCI_DEVICE_ID_INTEL_PATSBURG_SMBUS 0x1d22
/* Patsburg also has three 'Integrated Device Function' SMBus controllers */
@@ -1062,6 +1064,7 @@ static const struct pci_device_id i801_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CDF_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_EBG_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS) },
@@ -1749,6 +1752,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
case PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS:
case PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS:
case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS:
+ case PCI_DEVICE_ID_INTEL_EBG_SMBUS:
priv->features |= FEATURE_BLOCK_PROC;
priv->features |= FEATURE_I2C_BLOCK_READ;
priv->features |= FEATURE_IRQ;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H
2020-06-18 13:42 [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jarkko Nikula
@ 2020-06-18 13:42 ` Jarkko Nikula
2020-07-07 13:35 ` Jean Delvare
2020-08-05 9:37 ` Wolfram Sang
2020-07-07 13:33 ` [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jean Delvare
1 sibling, 2 replies; 6+ messages in thread
From: Jarkko Nikula @ 2020-06-18 13:42 UTC (permalink / raw)
To: linux-i2c; +Cc: Jean Delvare, Wolfram Sang, Jarkko Nikula
Add SMBus PCI ID on Intel Tiger Lake PCH-H.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
drivers/i2c/busses/i2c-i801.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 7797ef1d25d9..2df2551e9973 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -68,6 +68,7 @@
* Comet Lake-H (PCH) 0x06a3 32 hard yes yes yes
* Elkhart Lake (PCH) 0x4b23 32 hard yes yes yes
* Tiger Lake-LP (PCH) 0xa0a3 32 hard yes yes yes
+ * Tiger Lake-H (PCH) 0x43a3 32 hard yes yes yes
* Jasper Lake (SOC) 0x4da3 32 hard yes yes yes
* Comet Lake-V (PCH) 0xa3a3 32 hard yes yes yes
*
@@ -223,6 +224,7 @@
#define PCI_DEVICE_ID_INTEL_GEMINILAKE_SMBUS 0x31d4
#define PCI_DEVICE_ID_INTEL_ICELAKE_LP_SMBUS 0x34a3
#define PCI_DEVICE_ID_INTEL_5_3400_SERIES_SMBUS 0x3b30
+#define PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS 0x43a3
#define PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS 0x4b23
#define PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS 0x4da3
#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS 0x5ad4
@@ -1077,6 +1079,7 @@ static const struct pci_device_id i801_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_COMETLAKE_V_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS) },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS) },
{ 0, }
};
@@ -1751,6 +1754,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
case PCI_DEVICE_ID_INTEL_COMETLAKE_H_SMBUS:
case PCI_DEVICE_ID_INTEL_ELKHART_LAKE_SMBUS:
case PCI_DEVICE_ID_INTEL_TIGERLAKE_LP_SMBUS:
+ case PCI_DEVICE_ID_INTEL_TIGERLAKE_H_SMBUS:
case PCI_DEVICE_ID_INTEL_JASPER_LAKE_SMBUS:
case PCI_DEVICE_ID_INTEL_EBG_SMBUS:
priv->features |= FEATURE_BLOCK_PROC;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H
2020-06-18 13:42 ` [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H Jarkko Nikula
@ 2020-07-07 13:35 ` Jean Delvare
2020-08-05 9:37 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Jean Delvare @ 2020-07-07 13:35 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-i2c, Wolfram Sang
On Thu, 18 Jun 2020 16:42:40 +0300, Jarkko Nikula wrote:
> Add SMBus PCI ID on Intel Tiger Lake PCH-H.
s/ on / of / ?
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> drivers/i2c/busses/i2c-i801.c | 4 ++++
> 1 file changed, 4 insertions(+)
> (...)
Other than this (which Wolfram can probably fix on the fly):
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H
2020-06-18 13:42 ` [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H Jarkko Nikula
2020-07-07 13:35 ` Jean Delvare
@ 2020-08-05 9:37 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-08-05 9:37 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-i2c, Jean Delvare
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
On Thu, Jun 18, 2020 at 04:42:40PM +0300, Jarkko Nikula wrote:
> Add SMBus PCI ID on Intel Tiger Lake PCH-H.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH
2020-06-18 13:42 [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jarkko Nikula
2020-06-18 13:42 ` [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H Jarkko Nikula
@ 2020-07-07 13:33 ` Jean Delvare
2020-08-05 9:36 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2020-07-07 13:33 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-i2c, Wolfram Sang, Mika Westerberg
On Thu, 18 Jun 2020 16:42:39 +0300, Jarkko Nikula wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Add support for SMBus controller on Intel Emmitsburg PCH. This is the
> same IP as used in Cannon Lake and derivatives.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> Documentation/i2c/busses/i2c-i801.rst | 1 +
> drivers/i2c/busses/Kconfig | 1 +
> drivers/i2c/busses/i2c-i801.c | 4 ++++
> 3 files changed, 6 insertions(+)
> (...)
Signed-off-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH
2020-07-07 13:33 ` [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jean Delvare
@ 2020-08-05 9:36 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2020-08-05 9:36 UTC (permalink / raw)
To: Jean Delvare; +Cc: Jarkko Nikula, linux-i2c, Mika Westerberg
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Tue, Jul 07, 2020 at 03:33:24PM +0200, Jean Delvare wrote:
> On Thu, 18 Jun 2020 16:42:39 +0300, Jarkko Nikula wrote:
> > From: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Add support for SMBus controller on Intel Emmitsburg PCH. This is the
> > same IP as used in Cannon Lake and derivatives.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Converted Jean's SoB to Rev-by (that's why I missed it so far, sorry)
and applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-08-05 9:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-18 13:42 [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jarkko Nikula
2020-06-18 13:42 ` [PATCH 2/2] i2c: i801: Add support for Intel Tiger Lake PCH-H Jarkko Nikula
2020-07-07 13:35 ` Jean Delvare
2020-08-05 9:37 ` Wolfram Sang
2020-07-07 13:33 ` [PATCH 1/2] i2c: i801: Add support for Intel Emmitsburg PCH Jean Delvare
2020-08-05 9:36 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).