From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1882EC433DF for ; Tue, 23 Jun 2020 08:47:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFF1A20724 for ; Tue, 23 Jun 2020 08:47:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731709AbgFWIrK (ORCPT ); Tue, 23 Jun 2020 04:47:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:64401 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731158AbgFWIrK (ORCPT ); Tue, 23 Jun 2020 04:47:10 -0400 IronPort-SDR: fmXr1PDO/1VufpOwiGzAzZLKvJWtefPo9WbTXsEmBFI4eYbkoKow57pI2P+Ok34hs9S1yJITZK M8tyjYzqhJIw== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="162082284" X-IronPort-AV: E=Sophos;i="5.75,270,1589266800"; d="scan'208";a="162082284" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2020 01:47:09 -0700 IronPort-SDR: aLXLdcoE2J9MZ7IeYewcy86cKwlBC+GwitQSva/ggNV7LVe/NsDc+ZlrRV+lk8pdwEZshEsIde 4us1srmAkqFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,270,1589266800"; d="scan'208";a="263240527" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007.fm.intel.com with ESMTP; 23 Jun 2020 01:47:08 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1jneaE-00FKPr-BK; Tue, 23 Jun 2020 11:47:10 +0300 Date: Tue, 23 Jun 2020 11:47:10 +0300 From: Andy Shevchenko To: Jarkko Nikula Cc: linux-i2c@vger.kernel.org, Wolfram Sang , John Stultz Subject: Re: [PATCH] i2c: designware: Fix bus speed in !CONFIG_ACPI case Message-ID: <20200623084710.GQ2428291@smile.fi.intel.com> References: <20200623083113.241137-1-jarkko.nikula@linux.intel.com> <20200623084635.GP2428291@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200623084635.GP2428291@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, Jun 23, 2020 at 11:46:35AM +0300, Andy Shevchenko wrote: > On Tue, Jun 23, 2020 at 11:31:13AM +0300, Jarkko Nikula wrote: > > John Stultz reported that commit f9288fcc5c615 ("i2c: designware: Move > > ACPI parts into common module") caused a regression on the HiKey board > > where adv7511 HDMI bridge driver wasn't probing anymore due the I2C bus > > failed to start. > > > > It seems the change caused the bus speed being zero when CONFIG_ACPI > > not set and neither speed based on "clock-frequency" device property or > > default fast mode is set. > > > > Fix this by moving bus speed setting back to dw_i2c_plat_probe() and let > > the i2c_dw_acpi_adjust_bus_speed() adjust only speed from ACPI. > > I have slightly different idea, I'll send a patch soon after testing. Note, your patch breaks PCI case. -- With Best Regards, Andy Shevchenko