From: Wolfram Sang <wsa@the-dreams.de>
To: "Måns Rullgård" <mans@mansr.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: core: check returned size of emulated smbus block read
Date: Sun, 28 Jun 2020 20:20:15 +0200 [thread overview]
Message-ID: <20200628182015.GA1274@ninjato> (raw)
In-Reply-To: <yw1x1rm2vtml.fsf@mansr.com>
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
> I saw it with the mv64xxx (Allwinner) and omap (Beaglebone) drivers.
> From a quick look, it seems like quite a few others have the same
> problem.
Okay, well, to be fair, both drivers don't advertise
I2C_SMBUS_BLOCK_DATA. The client driver should check for that. Anyhow,
it makes sense to have your additional check in the core as fallback
safety.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-06-28 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-13 10:41 [PATCH] i2c: core: check returned size of emulated smbus block read Mans Rullgard
2020-06-26 8:22 ` Wolfram Sang
2020-06-26 13:33 ` Måns Rullgård
2020-06-28 18:20 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200628182015.GA1274@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).