public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: arnd@arndb.de, gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used
Date: Wed, 1 Jul 2020 10:36:16 +0100	[thread overview]
Message-ID: <20200701093616.GX1179328@dell> (raw)
In-Reply-To: <20200701083118.45744-27-lee.jones@linaro.org>

... as is the case when !CONFIG_ACPI.

Fixes the following W=1 kernel build warning:

 drivers/misc/eeprom/at24.c:228:36: warning: ‘at24_acpi_ids’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
- Resending to add the I2C ML and Bartosz to the conversation
  - Looks like I missed them when running get_maintainer.pl
- This patch, like all the others in the set, should go in via Misc
  - Although the patches are orthogonal, this makes life easier for Greg

 drivers/misc/eeprom/at24.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 9ff18d4961ceb..2591c21b2b5d8 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -225,7 +225,7 @@ static const struct of_device_id at24_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, at24_of_match);
 
-static const struct acpi_device_id at24_acpi_ids[] = {
+static const struct acpi_device_id __maybe_unused at24_acpi_ids[] = {
 	{ "INT3499",	(kernel_ulong_t)&at24_data_INT3499 },
 	{ "TPF0001",	(kernel_ulong_t)&at24_data_24c1024 },
 	{ /* END OF LIST */ }

       reply	other threads:[~2020-07-01  9:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200701083118.45744-1-lee.jones@linaro.org>
     [not found] ` <20200701083118.45744-27-lee.jones@linaro.org>
2020-07-01  9:36   ` Lee Jones [this message]
2020-07-06 17:16     ` [PATCH v2 26/30] misc: eeprom: at24: Tell the compiler that ACPI functions may not be used Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701093616.GX1179328@dell \
    --to=lee.jones@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox