From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Alain Volmat <alain.volmat@st.com>
Subject: Re: [RFC PATCH] WIP: i2c: rcar: add HostNotify support
Date: Wed, 1 Jul 2020 15:21:45 +0200 [thread overview]
Message-ID: <20200701132145.GJ2261@ninjato> (raw)
In-Reply-To: <20200701123207.GC3457@gnbcxd0016.gnb.st.com>
[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]
> > I got another idea. What about a boolean binding "smbus"?
...
>
> I much prefer this solution than the usage of the smbus_alert irq value
> (in case of the i2c-stm32f7). In that case, I'd only set smbus boolean
> to enable both SMBus Host-Notify & SMBus Alert.
Correct.
> In case of a device having a dedicated irq for SMBus Alert, smbus_alert
> irq binding would still be needed.
Yes, that was my idea. Let's use "smbus".
> Just my 2 cents about another aspect regarding SMBus Alert, since alert
> is coming from another pin and not the usual SCL / SCK, when SMBus Alert
> has to be used, there is a very good chance to have a pinctrl entry which
> is different from not using SMBus Alert.
> Indeed, even if we need SMBus, but don't need SMBus Alert, the SMBus Alert
> input pin might be used for something else.
> But this of course doesn't prevent to use the smbus boolean binding.
I am not sure if I fully get this point. Either we have a dedicated line
(your case) or we need to use a GPIO as an interrupt line (my case). So,
either this is configured correctly in DT and added as a "smbus_alert"
irq. Or this irq is missing and then the driver will ignore SMBusAlert
and the GPIO can be freely used/muxed. Or?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-01 13:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 8:09 [RFC PATCH] WIP: i2c: rcar: add HostNotify support Wolfram Sang
2020-07-01 9:27 ` Wolfram Sang
2020-07-01 12:16 ` Wolfram Sang
2020-07-01 12:32 ` Alain Volmat
2020-07-01 13:21 ` Wolfram Sang [this message]
2020-07-01 13:46 ` Alain Volmat
2020-07-01 14:00 ` Wolfram Sang
2020-07-01 14:37 ` Alain Volmat
2020-07-01 14:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701132145.GJ2261@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=alain.volmat@st.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).