From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ricardo Ribalda <ribalda@kernel.org>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi
Date: Thu, 2 Jul 2020 12:48:08 +0300 [thread overview]
Message-ID: <20200702094808.GP3703480@smile.fi.intel.com> (raw)
In-Reply-To: <20200702093832.2077252-1-ribalda@kernel.org>
On Thu, Jul 02, 2020 at 11:38:32AM +0200, Ricardo Ribalda wrote:
> Current AMD's zen-based APUs use this core for some of its i2c-buses.
>
> With this patch we re-enable autodetection of hwmon-alike devices, so
> lm-sensors will be able to work automatically.
>
> It does not affect the boot-time of embedded devices, as the class is
> set based on the dmi information.
dmi -> DMI
> Dmi is probed only on Qtechnology QT5222 Industrial Camera Platform
Dmi -> DMI
> https://qtec.com/camera-technology-camera-platforms/
Use DocLink: tag.
...
> +static const struct dmi_system_id allow_probe[] = {
allow_probe -> dw_i2c_hwmon_class_dmi
> + {
> + .ident = "Qtechnology QT5222",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "QT5222")
Comma is missed.
> + }
> + },
> +
Redundant.
> + { }
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-02 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 9:38 [PATCH v3] i2c: designware: platdrv: Set class based on dmi Ricardo Ribalda
2020-07-02 9:48 ` Andy Shevchenko [this message]
2020-07-02 9:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702094808.GP3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ribalda@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox