From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FF71C433E0 for ; Thu, 2 Jul 2020 09:50:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2921D20748 for ; Thu, 2 Jul 2020 09:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbgGBJuA (ORCPT ); Thu, 2 Jul 2020 05:50:00 -0400 Received: from mga05.intel.com ([192.55.52.43]:41396 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726475AbgGBJuA (ORCPT ); Thu, 2 Jul 2020 05:50:00 -0400 IronPort-SDR: 0zSfAUnuC4l0WCGHZw1rWCFrqGpXBmN20c40sUwQz0ch9RJ+7nILsaK7UmREFDMQmb9r5TPj3s +yyKCcLNMr+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="231714604" X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="231714604" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2020 02:49:59 -0700 IronPort-SDR: w9kj9NDzTtkykBa7/zC0z5r+hsQ2eXMt9ev/7o9ZxjlZ6+RtQ4YDIKjh7O8Jc/CPweKH78hgU3 BhzNTWPOyP6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,304,1589266800"; d="scan'208";a="481947976" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 02 Jul 2020 02:49:57 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1jqvqw-00HBIe-AB; Thu, 02 Jul 2020 12:49:58 +0300 Date: Thu, 2 Jul 2020 12:49:58 +0300 From: Andy Shevchenko To: Ricardo Ribalda Cc: Jarkko Nikula , Mika Westerberg , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Wolfram Sang Subject: Re: [PATCH v3] i2c: designware: platdrv: Set class based on dmi Message-ID: <20200702094958.GQ3703480@smile.fi.intel.com> References: <20200702093832.2077252-1-ribalda@kernel.org> <20200702094808.GP3703480@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200702094808.GP3703480@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Jul 02, 2020 at 12:48:08PM +0300, Andy Shevchenko wrote: > On Thu, Jul 02, 2020 at 11:38:32AM +0200, Ricardo Ribalda wrote: > > Current AMD's zen-based APUs use this core for some of its i2c-buses. > > > > With this patch we re-enable autodetection of hwmon-alike devices, so > > lm-sensors will be able to work automatically. > > > > It does not affect the boot-time of embedded devices, as the class is > > set based on the dmi information. > > dmi -> DMI ...and in the Subject. > > Dmi is probed only on Qtechnology QT5222 Industrial Camera Platform > > Dmi -> DMI ...and period at the end of sentence. > > https://qtec.com/camera-technology-camera-platforms/ > > Use DocLink: tag. > > ... > > > +static const struct dmi_system_id allow_probe[] = { > > allow_probe -> dw_i2c_hwmon_class_dmi > > > + { > > + .ident = "Qtechnology QT5222", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Qtechnology"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "QT5222") > > Comma is missed. > > > + } > > + }, > > > + > > Redundant. > > > + { } > > +}; > > -- > With Best Regards, > Andy Shevchenko > > -- With Best Regards, Andy Shevchenko