From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0760EC433E0 for ; Thu, 16 Jul 2020 18:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF7182074B for ; Thu, 16 Jul 2020 18:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728257AbgGPS03 (ORCPT ); Thu, 16 Jul 2020 14:26:29 -0400 Received: from mga11.intel.com ([192.55.52.93]:18196 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbgGPS03 (ORCPT ); Thu, 16 Jul 2020 14:26:29 -0400 IronPort-SDR: qGvNqRlJQCls0Rg38nwEwwzu2z3yh+E6zvWHGaKQvJ0q5Z32KSBoJZTXjQazdcX5AMvNXTIIkM JpIJnIIOr42g== X-IronPort-AV: E=McAfee;i="6000,8403,9684"; a="147461501" X-IronPort-AV: E=Sophos;i="5.75,360,1589266800"; d="scan'208";a="147461501" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jul 2020 11:26:27 -0700 IronPort-SDR: sNRhZZDdubKD2nsinea1jGjgLKdT7PBFxrDpzy+PP6d03Qh4m/FY1Nwk7Bje2doLA36MTzxcdz iN8ZJTJhzuNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,360,1589266800"; d="scan'208";a="361119837" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001.jf.intel.com with ESMTP; 16 Jul 2020 11:26:24 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1jw8aO-002CtJ-Lv; Thu, 16 Jul 2020 21:26:24 +0300 Date: Thu, 16 Jul 2020 21:26:24 +0300 From: Andy Shevchenko To: Rayagonda Kokatanur Cc: Wolfram Sang , linux-i2c , Linux Kernel Mailing List , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Lori Hikichi , Robert Richter , Nishka Dasgupta , linux-arm Mailing List Subject: Re: [PATCH V1 2/2] i2c: iproc: add slave pec support Message-ID: <20200716182624.GT3703480@smile.fi.intel.com> References: <20200716080836.2279-1-rayagonda.kokatanur@broadcom.com> <20200716080836.2279-3-rayagonda.kokatanur@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Thu, Jul 16, 2020 at 10:49:14PM +0530, Rayagonda Kokatanur wrote: > On Thu, Jul 16, 2020 at 3:44 PM Andy Shevchenko > wrote: > > On Thu, Jul 16, 2020 at 11:14 AM Rayagonda Kokatanur > > wrote: ... > > > -#define S_RX_PEC_ERR_SHIFT 29 > > > +#define S_RX_PEC_ERR_SHIFT 28 > > This needs to be explained in the commit message, in particular why > > this change makes no regression. > > I didn't get what do you mean by "no regression", please elaborate. The definition above has been changed. The point is you have to point out in the commit message why it's okay and makes no regression. For example, "..._SHIFT is changed to ... according to documentation. Since there was no user of it no regression will be made." Provide proper text, b/c I have no idea what is exactly the reason of the change and if it's indeed used to have no users. ... > > > + ret = bcm_iproc_smbus_check_slave_pec(iproc_i2c, > > > + val); > > > > One line looks better. > > Yes, but to have 80 char per line, I have to do this. We have more, but even if you stick with 80 the above is harder to get than if it is one line. -- With Best Regards, Andy Shevchenko