From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] i2c: rcar: slave: only send STOP event when we have been addressed
Date: Sun, 26 Jul 2020 14:30:58 +0200 [thread overview]
Message-ID: <20200726123058.GA2484@ninjato> (raw)
In-Reply-To: <20200629161506.20617-1-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Mon, Jun 29, 2020 at 06:15:06PM +0200, Wolfram Sang wrote:
> When the SSR interrupt is activated, it will detect every STOP condition
> on the bus, not only the ones after we have been addressed. So, enable
> this interrupt only after we have been addressed, and disable it
> otherwise.
>
> Fixes: de20d1857dd6 ("i2c: rcar: add slave support")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since v1: It is probably cleaner to clear the SSR flag before we
> enable the SSR interrupt.
I am going to apply v1 of this patch. The above is not cleaner. It is
cleaner to clear SAR only when we are done with everything to make sure
SCL is stretched long enough. Clearing SSR a tad later is still good
enough.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-07-26 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 16:15 [PATCH v2] i2c: rcar: slave: only send STOP event when we have been addressed Wolfram Sang
2020-07-26 12:30 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726123058.GA2484@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).