* [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()
@ 2020-07-16 14:53 Andy Shevchenko
2020-08-05 9:28 ` Wolfram Sang
2020-09-21 10:06 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-07-16 14:53 UTC (permalink / raw)
To: Ajay Gupta, linux-i2c, Wolfram Sang; +Cc: Andy Shevchenko
This makes the driver code slightly easier to read.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
index f480105000b8..f9a69b109e5c 100644
--- a/drivers/i2c/busses/i2c-nvidia-gpu.c
+++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
@@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len)
put_unaligned_be16(val, data);
break;
case 3:
- put_unaligned_be16(val >> 8, data);
- data[2] = val;
+ put_unaligned_be24(val, data);
break;
case 4:
put_unaligned_be32(val, data);
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()
2020-07-16 14:53 [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24() Andy Shevchenko
@ 2020-08-05 9:28 ` Wolfram Sang
2020-08-06 5:18 ` Ajay Gupta
2020-09-21 10:06 ` Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2020-08-05 9:28 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Ajay Gupta, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote:
> This makes the driver code slightly easier to read.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
Ajay, any comments?
> drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-nvidia-gpu.c
> index f480105000b8..f9a69b109e5c 100644
> --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> @@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8 *data, u16 len)
> put_unaligned_be16(val, data);
> break;
> case 3:
> - put_unaligned_be16(val >> 8, data);
> - data[2] = val;
> + put_unaligned_be24(val, data);
> break;
> case 4:
> put_unaligned_be32(val, data);
> --
> 2.27.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()
2020-08-05 9:28 ` Wolfram Sang
@ 2020-08-06 5:18 ` Ajay Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Ajay Gupta @ 2020-08-06 5:18 UTC (permalink / raw)
To: Wolfram Sang, Andy Shevchenko; +Cc: linux-i2c@vger.kernel.org
Hi Wolfram,
> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Sent: Wednesday, August 5, 2020 2:29 AM
> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Ajay Gupta <ajayg@nvidia.com>; linux-i2c@vger.kernel.org
> Subject: Re: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()
>
> On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote:
> > This makes the driver code slightly easier to read.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
>
> Ajay, any comments?
The change looks good to me.
Reviewed-by: Ajay Gupta <ajayg@nvidia.com>
Thanks
> nvpublic
>
> > drivers/i2c/busses/i2c-nvidia-gpu.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-nvidia-gpu.c b/drivers/i2c/busses/i2c-
> nvidia-gpu.c
> > index f480105000b8..f9a69b109e5c 100644
> > --- a/drivers/i2c/busses/i2c-nvidia-gpu.c
> > +++ b/drivers/i2c/busses/i2c-nvidia-gpu.c
> > @@ -125,8 +125,7 @@ static int gpu_i2c_read(struct gpu_i2c_dev *i2cd, u8
> *data, u16 len)
> > put_unaligned_be16(val, data);
> > break;
> > case 3:
> > - put_unaligned_be16(val >> 8, data);
> > - data[2] = val;
> > + put_unaligned_be24(val, data);
> > break;
> > case 4:
> > put_unaligned_be32(val, data);
> > --
> > 2.27.0
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24()
2020-07-16 14:53 [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24() Andy Shevchenko
2020-08-05 9:28 ` Wolfram Sang
@ 2020-09-21 10:06 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-09-21 10:06 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Ajay Gupta, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
On Thu, Jul 16, 2020 at 05:53:19PM +0300, Andy Shevchenko wrote:
> This makes the driver code slightly easier to read.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-21 10:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-16 14:53 [PATCH v1] i2c: nvidia-gpu: Use put_unaligned_be24() Andy Shevchenko
2020-08-05 9:28 ` Wolfram Sang
2020-08-06 5:18 ` Ajay Gupta
2020-09-21 10:06 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).