From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D760C433DF for ; Fri, 14 Aug 2020 19:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50D0720768 for ; Fri, 14 Aug 2020 19:05:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726285AbgHNTFB (ORCPT ); Fri, 14 Aug 2020 15:05:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:54210 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgHNTFB (ORCPT ); Fri, 14 Aug 2020 15:05:01 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k6f0d-009Qr4-LD; Fri, 14 Aug 2020 21:04:59 +0200 Date: Fri, 14 Aug 2020 21:04:59 +0200 From: Andrew Lunn To: Mohammed Billoo Cc: Peter Korsgaard , linux-i2c@vger.kernel.org Subject: Re: [PATCH 1/2] i2c: ocores: add gaisler to platform data Message-ID: <20200814190459.GE2239279@lunn.ch> References: <20200814163134.29493-1-mab@mab-labs.com> <20200814164907.GB2239279@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Fri, Aug 14, 2020 at 02:53:20PM -0400, Mohammed Billoo wrote: > Andrew, > > Thanks for the feedback. That makes sense. > > My use case was very specific that required these changes and I thought I'd > push them upstream for others. Basically, we have an FPGA over PCI that has > some IP, vendor-specific bridging to AHB, and then grlib to go to i2c (among > other controllers). When we load the pci driver we create and add a mfd device > that has the specific BAR as the resource, and the offset within the BAR for > the i2c controller. Looking back, all of this could be added to the device > tree, so what we've done so far may be an anti-pattern.  > > Would you still want this patch? I would prefer device tree. Andrew