From: Jean Delvare <jdelvare@suse.de>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] eeprom: at24: Add support for the Sony VAIO EEPROMs
Date: Mon, 24 Aug 2020 19:03:03 +0200 [thread overview]
Message-ID: <20200824190303.38e80f0c@endymion> (raw)
In-Reply-To: <CAMpxmJWUqCL=QRfrFdTh7E_PmJd8WL+yY5U+d1YBPtg8GRTuJg@mail.gmail.com>
On Tue, 18 Aug 2020 15:41:32 +0200, Bartosz Golaszewski wrote:
> On Fri, Aug 7, 2020 at 3:00 PM Jean Delvare <jdelvare@suse.de> wrote:
> >
> > Special handling of the Sony VAIO EEPROMs is the last feature of the
> > legacy eeprom driver that the at24 driver does not support. Adding
> > this would let us deprecate and eventually remove the legacy eeprom
> > driver.
> >
> > So add the option to specify a post-processing callback function that
> > is called after reading data from the EEPROM, before it is returned
> > to the user. The 24c02-vaio type is the first use case of that option:
> > the callback function will mask the sensitive data for non-root users
> > exactly as the legacy eeprom driver was doing.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > Bartosz, this is a different approach to solving the problem compared
> > to your suggestion. It's even more generic in a way. Let me know what
> > you think.
>
> Patch applied with a stray newline dropped.
Oh, I see it now. Sorry and that and thanks for catching and fixing it.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-08-24 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 13:00 [PATCH 1/2] eeprom: at24: Add support for the Sony VAIO EEPROMs Jean Delvare
2020-08-07 14:19 ` [PATCH 2/2 RFC] eeprom: at24: Tidy at24_read() Jean Delvare
2020-08-18 13:46 ` Bartosz Golaszewski
2020-08-25 6:38 ` Jean Delvare
2020-08-12 18:10 ` [PATCH 1/2] eeprom: at24: Add support for the Sony VAIO EEPROMs Bartosz Golaszewski
2020-08-18 13:41 ` Bartosz Golaszewski
2020-08-24 17:03 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824190303.38e80f0c@endymion \
--to=jdelvare@suse.de \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox