public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] decode-vaio: Scan more i2c buses
Date: Mon, 31 Aug 2020 15:04:05 +0200	[thread overview]
Message-ID: <20200831150405.1a2df039@endymion> (raw)
In-Reply-To: <20200831094855.GA1070@ninjato>

On Mon, 31 Aug 2020 11:48:55 +0200, Wolfram Sang wrote:
> > -for (my $i = 0, $found=0; $i <= 4 && !$found; $i++)
> > +for (my $i = 0, $found=0; $i <= 31 && !$found; $i++)  
> 
> To get rid of the problem entirely, can't we do something like this
> with shell globs? Pseudo code:
> 
> 	foreach (/sys/bus/i2c/devices/*-0057/eeprom)
> 		$found += <found device>
> 
> 	if (!$found)
> 		foreach (/proc/sys/dev/sensors/eeprom-i2c-*-57)
> 		check_old_interface
> 		$found += <found device>

You have hit my perl knowledge limits ;-)

I know that arbitrary limits are bad, but the thing is, I'm not sure if
there is any actual user left for that script. I adjusted it for the
at24 driver because *if* there are users left then things should keep
working. But I wrote all this in 2001, laptops from then are definitely
no longer in use, and at this point I have no idea if recent VAIO
laptops still have this EEPROM.

So until someone comes to me with a recent VAIO laptop that needs this,
I am reluctant to invest more time into this.

-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2020-08-31 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  8:02 [PATCH v2 1/3] There are several eeprom drivers Jean Delvare
2020-08-31  8:08 ` [PATCH v2 2/3] decode-vaio: Add support for the at24 driver Jean Delvare
2020-08-31  8:09 ` [PATCH v2 3/3] decode-vaio: Scan more i2c buses Jean Delvare
2020-08-31  9:48   ` Wolfram Sang
2020-08-31 13:04     ` Jean Delvare [this message]
2020-08-31 13:25       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831150405.1a2df039@endymion \
    --to=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox