From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 468DCC433E6 for ; Wed, 2 Sep 2020 08:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FD7520829 for ; Wed, 2 Sep 2020 08:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726247AbgIBI6v (ORCPT ); Wed, 2 Sep 2020 04:58:51 -0400 Received: from mga18.intel.com ([134.134.136.126]:28395 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgIBI6v (ORCPT ); Wed, 2 Sep 2020 04:58:51 -0400 IronPort-SDR: cOLo8EOE4vTVNq9EjbZul+UXQyilz/e4KhF7nEa+OFRiHviiVWUidgi86tTeN0BwW/hDCUBvVv gm61WFbsajeg== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="145039202" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="145039202" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 01:58:47 -0700 IronPort-SDR: 2CJGKaIlw/C2SVozeZwg1xN512nRjfKZQ7PytBv7Jg4gKlgIhwwX/EcPX2K5ZdHnnB0eUe0I2s 7GQXpBiZKF9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="331361247" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 02 Sep 2020 01:58:45 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kDOOg-00DfSo-2Y; Wed, 02 Sep 2020 11:45:38 +0300 Date: Wed, 2 Sep 2020 11:45:38 +0300 From: Andy Shevchenko To: Evan Nimmo Cc: wsa@kernel.org, jarkko.nikula@linux.intel.com, jdelvare@suse.de, chris.packham@alliedtelesis.co.nz, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after reset Message-ID: <20200902084538.GY1891694@smile.fi.intel.com> References: <20200901211747.20649-1-evan.nimmo@alliedtelesis.co.nz> <20200902084356.GX1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902084356.GX1891694@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Sep 02, 2020 at 11:43:56AM +0300, Andy Shevchenko wrote: > On Wed, Sep 02, 2020 at 09:17:47AM +1200, Evan Nimmo wrote: > > If something goes wrong (such as the SCL being stuck low) then we need > > to reset the PCA chip. The issue with this is that on reset we lose all > > config settings and the chip ends up in a disabled state which results > > in a lock up/high cpu usage. We need to re-apply any configuration that > > cpu -> CPU (I guess Wolfram can decide with this when applying) > > > had previously been set and re-enable the chip. > > FWIW, > Reviewed-by: Andy Shevchenko And actually you forgot Chris' tag... But I dunno if the moving struct definition is something that Chris might not like. -- With Best Regards, Andy Shevchenko