From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Michal Simek <michal.simek@xilinx.com>,
Sekhar Nori <nsekhar@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
Pierre-Yves MORDRET <pierre-yves.mordret@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 6/9] i2c: imx: Simplify with dev_err_probe()
Date: Thu, 3 Sep 2020 07:36:06 +0200 [thread overview]
Message-ID: <20200903053606.pwcqxoepj3vmlt4r@pengutronix.de> (raw)
In-Reply-To: <20200902150643.14839-6-krzk@kernel.org>
On Wed, Sep 02, 2020 at 05:06:40PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/i2c/busses/i2c-imx.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 0ab5381aa012..63f4367c312b 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -1159,11 +1159,9 @@ static int i2c_imx_probe(struct platform_device *pdev)
>
> /* Get I2C clock */
> i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
> - if (IS_ERR(i2c_imx->clk)) {
> - if (PTR_ERR(i2c_imx->clk) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "can't get I2C clock\n");
> - return PTR_ERR(i2c_imx->clk);
> - }
> + if (IS_ERR(i2c_imx->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c_imx->clk),
> + "can't get I2C clock\n");
>
> ret = clk_prepare_enable(i2c_imx->clk);
> if (ret) {
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-09-03 5:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:06 [PATCH 1/9] i2c: stm32: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-09-02 15:06 ` [PATCH 2/9] i2c: xiic: " Krzysztof Kozlowski
2021-06-23 8:57 ` Michal Simek
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 3/9] i2c: bcm2835: " Krzysztof Kozlowski
2020-09-02 15:24 ` Florian Fainelli
2020-09-10 6:25 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 4/9] i2c: cadence: " Krzysztof Kozlowski
2021-06-23 8:59 ` Michal Simek
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 5/9] i2c: davinci: " Krzysztof Kozlowski
2021-06-23 16:26 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 6/9] i2c: imx: " Krzysztof Kozlowski
2020-09-02 17:58 ` Uwe Kleine-König
2020-09-03 5:36 ` Oleksij Rempel [this message]
2020-09-10 6:27 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 7/9] i2c: rk3x: " Krzysztof Kozlowski
2020-09-22 14:25 ` Heiko Stübner
2020-09-27 18:01 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 8/9] i2c: mux: gpmux: " Krzysztof Kozlowski
2020-09-02 18:33 ` Peter Rosin
2020-09-10 6:24 ` Wolfram Sang
2020-09-02 15:06 ` [PATCH 9/9] i2c: mux: reg: " Krzysztof Kozlowski
2020-09-02 18:33 ` Peter Rosin
2020-09-10 6:24 ` Wolfram Sang
2020-09-10 9:36 ` [PATCH 1/9] i2c: stm32: " Alain Volmat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903053606.pwcqxoepj3vmlt4r@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=alexandre.torgue@st.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@rempel-privat.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nsaenzjulienne@suse.de \
--cc=nsekhar@ti.com \
--cc=peda@axentia.se \
--cc=pierre-yves.mordret@st.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).