From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
David Jedynak <sileasresearch@gmail.com>
Subject: Re: [PATCH] i2cset: Fix short writes with mask
Date: Tue, 8 Sep 2020 23:08:27 +0200 [thread overview]
Message-ID: <20200908230827.6c3ecd2f@endymion> (raw)
In-Reply-To: <20200908154029.GA1772@ninjato>
On Tue, 8 Sep 2020 17:40:29 +0200, Wolfram Sang wrote:
> Hi Jean,
>
> > Funny story, while I only posted this last week, I wrote the fix
> > several months ago, so last week I actually got to review my own code
> > with fresh eyes, and when I stumbled upon that specific change, first
> > thing that came to my mind was "this is a useless change, why did I do
> > that ?" Then I scrolled up, checked the other changes in that function,
> > noticed the removed "else" and said OK, I'm not that stupid after all
> > ;-)
>
> :) Now that there are two of us, maybe this justifies a short comment
> explaining it?
Well, the code itself isn't tricky, and it's only more of the same,
nothing new. The surprise was only for the patch reviewers, and now
this is cleared, and I committed the patch already. So I don't think
there's anything left to do.
Thanks,
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2020-09-08 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 9:00 [PATCH] i2cset: Fix short writes with mask Jean Delvare
2020-09-08 6:51 ` Wolfram Sang
2020-09-08 15:19 ` Jean Delvare
2020-09-08 15:40 ` Wolfram Sang
2020-09-08 21:08 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908230827.6c3ecd2f@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=sileasresearch@gmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).