From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A8FC2BC11 for ; Tue, 8 Sep 2020 21:08:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E27720659 for ; Tue, 8 Sep 2020 21:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728617AbgIHVIc (ORCPT ); Tue, 8 Sep 2020 17:08:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:37112 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728390AbgIHVIb (ORCPT ); Tue, 8 Sep 2020 17:08:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 812D0ADC5; Tue, 8 Sep 2020 21:08:29 +0000 (UTC) Date: Tue, 8 Sep 2020 23:08:27 +0200 From: Jean Delvare To: Wolfram Sang Cc: Linux I2C , David Jedynak Subject: Re: [PATCH] i2cset: Fix short writes with mask Message-ID: <20200908230827.6c3ecd2f@endymion> In-Reply-To: <20200908154029.GA1772@ninjato> References: <20200903110054.52a3a69f@endymion> <20200908065111.GA5936@ninjato> <20200908171908.65690731@endymion> <20200908154029.GA1772@ninjato> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-i2c-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Tue, 8 Sep 2020 17:40:29 +0200, Wolfram Sang wrote: > Hi Jean, > > > Funny story, while I only posted this last week, I wrote the fix > > several months ago, so last week I actually got to review my own code > > with fresh eyes, and when I stumbled upon that specific change, first > > thing that came to my mind was "this is a useless change, why did I do > > that ?" Then I scrolled up, checked the other changes in that function, > > noticed the removed "else" and said OK, I'm not that stupid after all > > ;-) > > :) Now that there are two of us, maybe this justifies a short comment > explaining it? Well, the code itself isn't tricky, and it's only more of the same, nothing new. The surprise was only for the patch reviewers, and now this is cleared, and I committed the patch already. So I don't think there's anything left to do. Thanks, -- Jean Delvare SUSE L3 Support