From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: "Volker Rümelin" <volker.ruemelin@googlemail.com>,
"Linux I2C" <linux-i2c@vger.kernel.org>,
"Bjorn Helgaas" <helgaas@kernel.org>,
"Vaibhav Gupta" <vaibhavgupta40@gmail.com>
Subject: Re: [PATCH v2 1/2] i2c: i801: Fix resume bug
Date: Thu, 10 Sep 2020 11:32:01 +0200 [thread overview]
Message-ID: <20200910113201.54f4db6f@endymion> (raw)
In-Reply-To: <20200910070913.GI1031@ninjato>
Hi Wolfram,
On Thu, 10 Sep 2020 09:09:13 +0200, Wolfram Sang wrote:
> On Sun, Sep 06, 2020 at 10:00:50AM +0200, Volker Rümelin wrote:
> > with these two patches the code in i2c-i801.c looks really good.
> >
> > But there is an issue with the reproducer.
>
> I am not familiar with the HW; do we want these two patches here or does
> the issue below need to be solved first? And if we want them, is it
> still stable material?
The new issue pointed out by Volker is independent from the bug being
fixed here. We do want these 2 patches applied now, with the 1st one
being stable material. The second patch is only a clean-up so it
doesn't need to go to stable.
This new issue exists since April 2018. I'm surprised it wasn't
reported as a regression earlier. Maybe newer BIOSes are getting better
at not making assumptions about register states at suspend time (let me
dream!) Anyway, it deserves its own fix, which also qualifies for
stable in my opinion.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2020-09-10 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 13:22 [PATCH v2 1/2] i2c: i801: Fix resume bug Jean Delvare
2020-09-01 13:28 ` [PATCH v2 2/2] i2c: i801: Simplify the suspend callback Jean Delvare
2020-09-14 7:03 ` Wolfram Sang
2020-09-03 17:17 ` [PATCH v2 1/2] i2c: i801: Fix resume bug Jean Delvare
2020-09-06 8:00 ` Volker Rümelin
2020-09-10 7:09 ` Wolfram Sang
2020-09-10 9:32 ` Jean Delvare [this message]
2020-09-10 9:14 ` Jean Delvare
2020-09-14 7:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910113201.54f4db6f@endymion \
--to=jdelvare@suse.de \
--cc=helgaas@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=vaibhavgupta40@gmail.com \
--cc=volker.ruemelin@googlemail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).