From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8A9C43464 for ; Mon, 21 Sep 2020 07:21:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5354220809 for ; Mon, 21 Sep 2020 07:21:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbgIUHVj (ORCPT ); Mon, 21 Sep 2020 03:21:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:49362 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726244AbgIUHVj (ORCPT ); Mon, 21 Sep 2020 03:21:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5AAAAF31; Mon, 21 Sep 2020 07:22:14 +0000 (UTC) Date: Mon, 21 Sep 2020 09:21:37 +0200 From: Jean Delvare To: Wolfram Sang Cc: linux-i2c@vger.kernel.org Subject: Re: [PATCH] misc: eeprom: use helper to get i2c_client from kobj Message-ID: <20200921092137.3f05d088@endymion> In-Reply-To: <20200919065615.4939-1-wsa+renesas@sang-engineering.com> References: <20200919065615.4939-1-wsa+renesas@sang-engineering.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Sat, 19 Sep 2020 08:56:15 +0200, Wolfram Sang wrote: > Slightly easier to read. > > Signed-off-by: Wolfram Sang > --- > drivers/misc/eeprom/eeprom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c > index 226b5efa6a77..34fa385dfd4b 100644 > --- a/drivers/misc/eeprom/eeprom.c > +++ b/drivers/misc/eeprom/eeprom.c > @@ -76,7 +76,7 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, > struct bin_attribute *bin_attr, > char *buf, loff_t off, size_t count) > { > - struct i2c_client *client = to_i2c_client(kobj_to_dev(kobj)); > + struct i2c_client *client = kobj_to_i2c_client(kobj); > struct eeprom_data *data = i2c_get_clientdata(client); > u8 slice; > Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support