From: Wolfram Sang <wsa@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Oleksij Rempel <linux@rempel-privat.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] i2c: imx: Fix external abort on interrupt in exit paths
Date: Sun, 27 Sep 2020 20:02:19 +0200 [thread overview]
Message-ID: <20200927180219.GF19475@kunai> (raw)
In-Reply-To: <20200920211238.13920-1-krzk@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2141 bytes --]
On Sun, Sep 20, 2020 at 11:12:38PM +0200, Krzysztof Kozlowski wrote:
> If interrupt comes late, during probe error path or device remove (could
> be triggered with CONFIG_DEBUG_SHIRQ), the interrupt handler
> i2c_imx_isr() will access registers with the clock being disabled. This
> leads to external abort on non-linefetch on Toradex Colibri VF50 module
> (with Vybrid VF5xx):
>
> Unhandled fault: external abort on non-linefetch (0x1008) at 0x8882d003
> Internal error: : 1008 [#1] ARM
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Not tainted 5.7.0 #607
> Hardware name: Freescale Vybrid VF5xx/VF6xx (Device Tree)
> (i2c_imx_isr) from [<8017009c>] (free_irq+0x25c/0x3b0)
> (free_irq) from [<805844ec>] (release_nodes+0x178/0x284)
> (release_nodes) from [<80580030>] (really_probe+0x10c/0x348)
> (really_probe) from [<80580380>] (driver_probe_device+0x60/0x170)
> (driver_probe_device) from [<80580630>] (device_driver_attach+0x58/0x60)
> (device_driver_attach) from [<805806bc>] (__driver_attach+0x84/0xc0)
> (__driver_attach) from [<8057e228>] (bus_for_each_dev+0x68/0xb4)
> (bus_for_each_dev) from [<8057f3ec>] (bus_add_driver+0x144/0x1ec)
> (bus_add_driver) from [<80581320>] (driver_register+0x78/0x110)
> (driver_register) from [<8010213c>] (do_one_initcall+0xa8/0x2f4)
> (do_one_initcall) from [<80c0100c>] (kernel_init_freeable+0x178/0x1dc)
> (kernel_init_freeable) from [<80807048>] (kernel_init+0x8/0x110)
> (kernel_init) from [<80100114>] (ret_from_fork+0x14/0x20)
>
> Additionally, the i2c_imx_isr() could wake up the wait queue
> (imx_i2c_struct->queue) before its initialization happens.
>
> The resource-managed framework should not be used for interrupt handling,
> because the resource will be released too late - after disabling clocks.
> The interrupt handler is not prepared for such case.
>
> Fixes: 1c4b6c3bcf30 ("i2c: imx: implement bus recovery")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-09-27 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 21:12 [PATCH v3] i2c: imx: Fix external abort on interrupt in exit paths Krzysztof Kozlowski
2020-09-25 5:38 ` Oleksij Rempel
2020-09-27 18:02 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927180219.GF19475@kunai \
--to=wsa@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).