From: Vadim Pasternak <vadimp@nvidia.com>
To: wsa@the-dreams.de
Cc: peda@axentia.se, linux-i2c@vger.kernel.org,
Vadim Pasternak <vadimp@nvidia.com>
Subject: [Re-send: PATCH i2c-next 6/6] i2c: mux: mlxcpld: Extend supported mux number
Date: Wed, 18 Nov 2020 16:44:16 +0200 [thread overview]
Message-ID: <20201118144416.184120-7-vadimp@nvidia.com> (raw)
In-Reply-To: <20201118144416.184120-1-vadimp@nvidia.com>
Allow to extend mux number supported by driver.
Currently it is limited by eight, which is not enough for new coming
Mellanox modular system with line cards, which require up to 64 mux
support.
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Michael Shych <michaelsh@nvidia.com>
---
drivers/i2c/muxes/i2c-mux-mlxcpld.c | 17 +++++------------
include/linux/platform_data/mlxcpld.h | 3 +++
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
index c76180919fc3..760636b507fa 100644
--- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c
+++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
@@ -15,8 +15,6 @@
#include <linux/platform_device.h>
#include <linux/slab.h>
-#define CPLD_MUX_MAX_NCHANS 8
-
/* mlxcpld_mux - mux control structure:
* @last_chan - last register value
* @client - I2C device client
@@ -24,7 +22,7 @@
* @sel_buf: I2C message buffer for mux select 16 bits transactions
*/
struct mlxcpld_mux {
- u8 last_chan;
+ int last_chan;
struct i2c_client *client;
struct mlxcpld_mux_plat_data pdata;
u8 sel_buf[3];
@@ -94,7 +92,6 @@ static int mlxcpld_mux_select_chan(struct i2c_mux_core *muxc, u32 chan)
int err = 0;
/* Only select the channel if its different from the last channel */
- chan++;
if (mux->last_chan != chan) {
err = mlxcpld_mux_reg_write(muxc->parent, mux, chan);
mux->last_chan = err < 0 ? 0 : chan;
@@ -143,7 +140,7 @@ static int mlxcpld_mux_probe(struct platform_device *pdev)
if (!i2c_check_functionality(client->adapter, func))
return -ENODEV;
- muxc = i2c_mux_alloc(client->adapter, &pdev->dev, CPLD_MUX_MAX_NCHANS,
+ muxc = i2c_mux_alloc(client->adapter, &pdev->dev, pdata->num_adaps,
sizeof(*data), 0, mlxcpld_mux_select_chan,
mlxcpld_mux_deselect);
if (!muxc)
@@ -158,13 +155,9 @@ static int mlxcpld_mux_probe(struct platform_device *pdev)
data->last_chan = 0; /* force the first selection */
/* Create an adapter for each channel. */
- for (num = 0; num < CPLD_MUX_MAX_NCHANS; num++) {
- if (num >= pdata->num_adaps)
- /* discard unconfigured channels */
- break;
-
- force = pdata->adap_ids[num];
-
+ for (num = 0; num < pdata->num_adaps; num++) {
+ force = pdata->base_nr ? (pdata->base_nr +
+ pdata->adap_ids[num]) : pdata->adap_ids[num];
err = i2c_mux_add_adapter(muxc, force, num, 0);
if (err)
goto virt_reg_failed;
diff --git a/include/linux/platform_data/mlxcpld.h b/include/linux/platform_data/mlxcpld.h
index da4f7e8f5721..ea88817b3b35 100644
--- a/include/linux/platform_data/mlxcpld.h
+++ b/include/linux/platform_data/mlxcpld.h
@@ -11,12 +11,15 @@
/* Platform data for the CPLD I2C multiplexers */
/* mlxcpld_mux_plat_data - per mux data, used with i2c_register_board_info
+ * @base_nr: base I2C bus number to number adapters from or zero for setting
+ * to adap_ids vector
* @adap_ids - adapter array
* @num_adaps - number of adapters
* @sel_reg_addr - mux select register offset in CPLD space
* @reg_size: register size in bytes (default 0 - 1 byte data, 1 - 2 bytes data
*/
struct mlxcpld_mux_plat_data {
+ int base_nr;
int *adap_ids;
int num_adaps;
int sel_reg_addr;
--
2.11.0
next prev parent reply other threads:[~2020-11-18 14:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:44 [Re-send: PATCH i2c-next 0/6] i2c: mux: mlxcpld: Extend driver functionality and update licenses Vadim Pasternak
2020-11-18 14:44 ` [Re-send: PATCH i2c-next 1/6] i2c: mux: mlxcpld: Update module license Vadim Pasternak
2020-11-18 14:44 ` [Re-send: PATCH i2c-next 2/6] platform/x86: " Vadim Pasternak
2020-11-18 14:44 ` [Re-send: PATCH i2c-next 3/6] i2c: mux: mlxcpld: Move header file out of x86 realm Vadim Pasternak
2020-11-18 14:44 ` [Re-send: PATCH i2c-next 4/6] i2c: mux: mlxcpld: Convert driver to platform driver Vadim Pasternak
2021-01-07 7:52 ` Peter Rosin
2020-11-18 14:44 ` [Re-send: PATCH i2c-next 5/6] i2c: mux: mlxcpld: Extend driver to support word address space devices Vadim Pasternak
2021-01-07 10:03 ` Peter Rosin
2021-01-07 20:43 ` Vadim Pasternak
2021-01-08 8:02 ` Peter Rosin
2021-01-11 18:11 ` Vadim Pasternak
2021-01-11 21:22 ` Peter Rosin
2021-01-11 23:24 ` Vadim Pasternak
2021-01-12 9:35 ` Peter Rosin
2021-01-12 10:11 ` wsa
2021-01-14 7:49 ` Peter Rosin
2021-01-14 18:43 ` Vadim Pasternak
2021-01-14 21:10 ` Peter Rosin
2021-01-14 21:13 ` Vadim Pasternak
2020-11-18 14:44 ` Vadim Pasternak [this message]
2021-01-07 10:10 ` [Re-send: PATCH i2c-next 6/6] i2c: mux: mlxcpld: Extend supported mux number Peter Rosin
2021-01-05 10:27 ` [Re-send: PATCH i2c-next 0/6] i2c: mux: mlxcpld: Extend driver functionality and update licenses Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2020-11-18 13:49 Vadim Pasternak
2020-11-18 13:49 ` [Re-send: PATCH i2c-next 6/6] i2c: mux: mlxcpld: Extend supported mux number Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118144416.184120-7-vadimp@nvidia.com \
--to=vadimp@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).