From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E18C71155 for ; Mon, 30 Nov 2020 17:46:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5253A20789 for ; Mon, 30 Nov 2020 17:46:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387470AbgK3Rqi (ORCPT ); Mon, 30 Nov 2020 12:46:38 -0500 Received: from mga14.intel.com ([192.55.52.115]:28016 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728531AbgK3Rqi (ORCPT ); Mon, 30 Nov 2020 12:46:38 -0500 IronPort-SDR: SvOJASuBD6pJ+/ZVnpb8mefeHSAfc3nmKINsNMdzASxcLzs/v/7fqlue9TQCNTEUlE8w4v6ns2 kBPSNYb7ZNbw== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="171893094" X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="171893094" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 09:44:47 -0800 IronPort-SDR: K4Lv8VYpHyuLxAvAG2Xpm2yVewTVRu28dNF0l6nBMlELHaKVXu14CV1XJ8Gqp3iWWE7ypM9g8H vTP4T4Saasgw== X-IronPort-AV: E=Sophos;i="5.78,382,1599548400"; d="scan'208";a="372578999" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2020 09:44:41 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kjnF8-00B69B-48; Mon, 30 Nov 2020 19:45:42 +0200 Date: Mon, 30 Nov 2020 19:45:42 +0200 From: Andy Shevchenko To: Daniel Scally Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mika.westerberg@linux.intel.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, wsa@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, mchehab@kernel.org, robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com, rostedt@goodmis.org, sergey.senozhatsky@gmail.com, linux@rasmusvillemoes.dk, kieran.bingham+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, laurent.pinchart+renesas@ideasonboard.com, jorhand@linux.microsoft.com, kitakar@gmail.com, heikki.krogerus@linux.intel.com Subject: Re: [PATCH 05/18] software_node: Alter software_node_unregister_nodes() to unregister the array in reverse order Message-ID: <20201130174542.GQ4077@smile.fi.intel.com> References: <20201130133129.1024662-1-djrscally@gmail.com> <20201130133129.1024662-6-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130133129.1024662-6-djrscally@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Mon, Nov 30, 2020 at 01:31:16PM +0000, Daniel Scally wrote: > Software nodes that are children of another software node should be > unregistered before their parent. To allow easy unregistering of an array > of software_nodes ordered parent to child, reverse the order in which > this function unregisters software_nodes. Should be folded in the previous patch. Otherwise we will have a history point where register() behaves differently to unregister(). ... > + * @nodes: Zero terminated array of software nodes to be unregistered. If > + * parent pointers are set up in any of the software nodes then the array > + * MUST be ordered such that parents come before their children. Please, leave field description short. Rather add another note to the Description below. > * > * Unregister multiple software nodes at once. > * > - * NOTE: Be careful using this call if the nodes had parent pointers set up in > - * them before registering. If so, it is wiser to remove the nodes > - * individually, in the correct order (child before parent) instead of relying > - * on the sequential order of the list of nodes in the array. > + * NOTE: If you are uncertain whether the array is ordered such that > + * parents will be unregistered before their children, it is wiser to > + * remove the nodes individually, in the correct order (child before > + * parent). > */ -- With Best Regards, Andy Shevchenko