From: Wolfram Sang <wsa@kernel.org>
To: "Stefan Lässer" <stefan.laesser@omicronenergy.com>
Cc: peter@korsgaard.com, andrew@lunn.ch, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: ocores: Avoid false-positive error log message.
Date: Thu, 3 Dec 2020 21:16:54 +0100 [thread overview]
Message-ID: <20201203201654.GB3585@kunai> (raw)
In-Reply-To: <6185f3fc-35ed-4de2-8bf7-fb991555580c@EXC03-ATKLA.omicron.at>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Thu, Dec 03, 2020 at 04:02:52PM +0100, Stefan Lässer wrote:
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()"), platform_get_irq() will call dev_err() on an error.
> In case of i2c ocores this leads to a false-positive error being logged:
>
> [ 4.173989] 007: ocores-i2c ocores-i2c: IRQ index 0 not found
>
> i2c ocores already handles the case when the IRQ cannot be found and
> therefore there is no benefit in having this error message being logged.
>
> This commit switches to platform_get_irq_optional(), which does not log
> in case the IRQ cannot be found.
>
> Signed-off-by: Stefan Lässer <stefan.laesser@omicronenergy.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-03 20:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 15:02 [PATCH] i2c: ocores: Avoid false-positive error log message Stefan Lässer
2020-12-03 15:20 ` Andrew Lunn
2020-12-03 17:19 ` Peter Korsgaard
2020-12-03 20:16 ` Wolfram Sang [this message]
2020-12-03 20:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203201654.GB3585@kunai \
--to=wsa@kernel.org \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=stefan.laesser@omicronenergy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).