From: Diego Santa Cruz <Diego.SantaCruz@spinetix.com>
To: bgolaszewski@baylibre.com
Cc: linux-i2c@vger.kernel.org,
Diego Santa Cruz <Diego.SantaCruz@spinetix.com>
Subject: [PATCH] misc: eeprom: at24: fix NVMEM name with custom AT24 device name
Date: Thu, 3 Dec 2020 22:47:03 +0100 [thread overview]
Message-ID: <20201203214703.18258-1-Diego.SantaCruz@spinetix.com> (raw)
When the "label" property is set on the AT24 EEPROM the NVMEM devid is
set to NVMEM_DEVID_NONE, but it is not effective since there is a
leftover line setting it back to NVMEM_DEVID_AUTO a few lines after.
Fixes: 61f764c307f6 ("eeprom: at24: Support custom device names for AT24 EEPROMs")
Signed-off-by: Diego Santa Cruz <Diego.SantaCruz@spinetix.com>
---
drivers/misc/eeprom/at24.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 35fabaf539b7..fbf69148b5ad 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -704,7 +704,6 @@ static int at24_probe(struct i2c_client *client)
nvmem_config.type = NVMEM_TYPE_EEPROM;
nvmem_config.dev = dev;
- nvmem_config.id = NVMEM_DEVID_AUTO;
nvmem_config.read_only = !writable;
nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
nvmem_config.owner = THIS_MODULE;
--
2.18.4
next reply other threads:[~2020-12-03 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 21:47 Diego Santa Cruz [this message]
2020-12-04 9:45 ` [PATCH] misc: eeprom: at24: fix NVMEM name with custom AT24 device name Bartosz Golaszewski
[not found] <20201203214703.18258-1-Diego.SantaCruz () spinetix ! com>
2021-06-01 12:15 ` Alexander Fomichev
2021-06-01 16:23 ` Diego Santa Cruz
2021-06-02 16:26 ` Alexander Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203214703.18258-1-Diego.SantaCruz@spinetix.com \
--to=diego.santacruz@spinetix.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox