From: Wolfram Sang <wsa@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Vadim Pasternak <vadimp@mellanox.com>,
Khalil Blaiech <kblaiech@mellanox.com>,
Arnd Bergmann <arnd@arndb.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jean Delvare <jdelvare@suse.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE
Date: Sat, 5 Dec 2020 14:49:07 +0100 [thread overview]
Message-ID: <20201205134907.GA5761@kunai> (raw)
In-Reply-To: <20201203223311.1251788-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
On Thu, Dec 03, 2020 at 11:32:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> If this is not enabled, the interfaces used in this driver do not work:
>
> drivers/i2c/busses/i2c-mlxbf.c:1888:3: error: implicit declaration of function 'i2c_slave_event' [-Werror,-Wimplicit-function-declaration]
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1888:26: error: use of undeclared identifier 'I2C_SLAVE_WRITE_REQUESTED'
> i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1890:32: error: use of undeclared identifier 'I2C_SLAVE_WRITE_RECEIVED'
> ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED,
> ^
> drivers/i2c/busses/i2c-mlxbf.c:1892:26: error: use of undeclared identifier 'I2C_SLAVE_STOP'
> i2c_slave_event(slave, I2C_SLAVE_STOP, &value);
> ^
>
> Fixes: b5b5b32081cd ("i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-12-05 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 22:32 [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE Arnd Bergmann
2020-12-05 1:42 ` Khalil Blaiech
2020-12-05 13:49 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201205134907.GA5761@kunai \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=kblaiech@mellanox.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).