linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs
@ 2020-11-19 23:55 Cristian Ciocaltea
  2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
                   ` (4 more replies)
  0 siblings, 5 replies; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:55 UTC (permalink / raw)
  To: Rob Herring, Andreas Färber, Manivannan Sadhasivam,
	Vinod Koul, Wolfram Sang, Ulf Hansson, Dan Williams
  Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel,
	dmaengine, linux-i2c, linux-mmc

Hi,

This patchset brings a series of improvements for the Actions Semi S500
SoCs family, by adding support for Clock & Reset Management Units, DMA,
MMC, I2C & SIRQ controllers.

Please note the patches consist mostly of DTS and bindings/compatibles
changes, since all the work they depend on has been already merged,
i.e. clock fixes/additions, pinctrl driver, sirq driver.

For the moment, I have only enabled the features I could test on
RoseapplePi SBC.

Thanks,
Cristi

Changes in v2:
- Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
- Added support for the SIRQ controller
- Added new entries in MAINTAINERS
- Updated naming of some patches in v1

Cristian Ciocaltea (18):
  arm: dts: owl-s500: Add Clock Management Unit
  arm: dts: owl-s500: Set CMU clocks for UARTs
  arm: dts: owl-s500: Add Reset controller
  dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
  dmaengine: owl: Add compatible for the Actions Semi S500 DMA
    controller
  arm: dts: owl-s500: Add DMA controller
  arm: dts: owl-s500: Add pinctrl & GPIO support
  dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
  arm: dts: owl-s500: Add MMC support
  dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
  MAINTAINERS: Update entry for Actions Semi Owl I2C binding
  i2c: owl: Add compatible for the Actions Semi S500 I2C controller
  arm: dts: owl-s500: Add I2C support
  arm: dts: owl-s500: Add SIRQ controller
  arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
  arm: dts: owl-s500-roseapplepi: Add uSD support
  arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
  MAINTAINERS: Add linux-actions ML for Actions Semi Arch

 .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
 .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
 .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
 .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
 MAINTAINERS                                   |   3 +-
 arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
 arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
 drivers/dma/owl-dma.c                         |   1 +
 drivers/i2c/busses/i2c-owl.c                  |   1 +
 9 files changed, 304 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml

-- 
2.29.2


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
  2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
@ 2020-11-19 23:56 ` Cristian Ciocaltea
  2020-12-07 22:12   ` Rob Herring
  2020-12-09 20:22   ` Wolfram Sang
  2020-11-19 23:56 ` [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding Cristian Ciocaltea
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:56 UTC (permalink / raw)
  To: Rob Herring, Wolfram Sang, Andreas Färber,
	Manivannan Sadhasivam
  Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel,
	linux-i2c

Convert the Actions Semi Owl I2C DT binding to a YAML schema for
enabling DT validation.

Additionally, add a new compatible string corresponding to the I2C
controller found in the S500 variant of the Actions Semi Owl SoCs
family.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
 .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
 .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml

diff --git a/Documentation/devicetree/bindings/i2c/i2c-owl.txt b/Documentation/devicetree/bindings/i2c/i2c-owl.txt
deleted file mode 100644
index 54c05dbdb2e4..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-owl.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-Actions Semiconductor Owl I2C controller
-
-Required properties:
-
-- compatible        : Should be one of the following:
-		      - "actions,s700-i2c" for S700 SoC
-		      - "actions,s900-i2c" for S900 SoC
-- reg               : Offset and length of the register set for the device.
-- #address-cells    : Should be 1.
-- #size-cells       : Should be 0.
-- interrupts        : A single interrupt specifier.
-- clocks            : Phandle of the clock feeding the I2C controller.
-
-Optional properties:
-
-- clock-frequency   : Desired I2C bus clock frequency in Hz. As only Normal and
-                      Fast modes are supported, possible values are 100000 and
-                      400000.
-Examples:
-
-        i2c0: i2c@e0170000 {
-                compatible = "actions,s900-i2c";
-                reg = <0 0xe0170000 0 0x1000>;
-                #address-cells = <1>;
-                #size-cells = <0>;
-                interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
-                clocks = <&clock CLK_I2C0>;
-                clock-frequency = <100000>;
-        };
diff --git a/Documentation/devicetree/bindings/i2c/i2c-owl.yaml b/Documentation/devicetree/bindings/i2c/i2c-owl.yaml
new file mode 100644
index 000000000000..d96908badf81
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/i2c-owl.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/i2c/i2c-owl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Actions Semi Owl I2C Controller
+
+maintainers:
+  - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
+
+description: |
+  This I2C controller is found in the Actions Semi Owl SoCs:
+  S500, S700 and S900.
+
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - actions,s500-i2c # Actions Semi S500 compatible SoCs
+      - actions,s700-i2c # Actions Semi S700 compatible SoCs
+      - actions,s900-i2c # Actions Semi S900 compatible SoCs
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    description: Phandle of the clock feeding the I2C controller.
+    minItems: 1
+
+  clock-frequency:
+    description: |
+      Desired I2C bus clock frequency in Hz. As only Standard and Fast
+      modes are supported, possible values are 100000 and 400000.
+    enum: [100000, 400000]
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/actions,s900-cmu.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    i2c@e0170000 {
+        compatible = "actions,s900-i2c";
+        reg = <0xe0170000 0x1000>;
+        interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+        clocks = <&cmu CLK_I2C0>;
+        clock-frequency = <100000>;
+    };
+
+...
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding
  2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
  2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
@ 2020-11-19 23:56 ` Cristian Ciocaltea
  2020-12-09 20:22   ` Wolfram Sang
  2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:56 UTC (permalink / raw)
  To: Wolfram Sang, Andreas Färber, Manivannan Sadhasivam
  Cc: linux-arm-kernel, linux-actions, linux-kernel, linux-i2c

The Actions Semi Owl I2C DT binding has been converted to YAML schema,
therefore update accordingly the entry in MAINTAINERS.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e451dcce054f..a85c1881cf07 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1501,7 +1501,7 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
 F:	Documentation/devicetree/bindings/dma/owl-dma.yaml
-F:	Documentation/devicetree/bindings/i2c/i2c-owl.txt
+F:	Documentation/devicetree/bindings/i2c/i2c-owl.yaml
 F:	Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml
 F:	Documentation/devicetree/bindings/mmc/owl-mmc.yaml
 F:	Documentation/devicetree/bindings/pinctrl/actions,*
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller
  2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
  2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
  2020-11-19 23:56 ` [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding Cristian Ciocaltea
@ 2020-11-19 23:56 ` Cristian Ciocaltea
  2020-11-28  7:19   ` Manivannan Sadhasivam
                     ` (2 more replies)
  2020-11-19 23:56 ` [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support Cristian Ciocaltea
  2020-12-05  6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
  4 siblings, 3 replies; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:56 UTC (permalink / raw)
  To: Wolfram Sang, Rob Herring, Andreas Färber,
	Manivannan Sadhasivam
  Cc: linux-arm-kernel, linux-actions, linux-kernel, linux-i2c

Add S500 variant to the list of devices supported by the Actions Semi
Owl I2C driver.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
 drivers/i2c/busses/i2c-owl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
index 5cf5a119a6ad..98882fe4e965 100644
--- a/drivers/i2c/busses/i2c-owl.c
+++ b/drivers/i2c/busses/i2c-owl.c
@@ -508,6 +508,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id owl_i2c_of_match[] = {
+	{ .compatible = "actions,s500-i2c" },
 	{ .compatible = "actions,s700-i2c" },
 	{ .compatible = "actions,s900-i2c" },
 	{ /* sentinel */ }
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support
  2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
                   ` (2 preceding siblings ...)
  2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
@ 2020-11-19 23:56 ` Cristian Ciocaltea
  2020-11-28  7:35   ` Manivannan Sadhasivam
  2020-12-05  6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
  4 siblings, 1 reply; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-11-19 23:56 UTC (permalink / raw)
  To: Rob Herring, Wolfram Sang, Andreas Färber,
	Manivannan Sadhasivam
  Cc: devicetree, linux-arm-kernel, linux-actions, linux-kernel,
	linux-i2c

Add I2C controller nodes for Actions Semi S500 SoC.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
---
 arch/arm/boot/dts/owl-s500.dtsi | 40 +++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi
index 7af7c9e1119d..55f8b8c2e149 100644
--- a/arch/arm/boot/dts/owl-s500.dtsi
+++ b/arch/arm/boot/dts/owl-s500.dtsi
@@ -193,6 +193,46 @@ cmu: clock-controller@b0160000 {
 			#reset-cells = <1>;
 		};
 
+		i2c0: i2c@b0170000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0170000 0x4000>;
+			clocks = <&cmu CLK_I2C0>;
+			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c1: i2c@b0174000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0174000 0x4000>;
+			clocks = <&cmu CLK_I2C1>;
+			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c2: i2c@b0178000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0178000 0x4000>;
+			clocks = <&cmu CLK_I2C2>;
+			interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c3: i2c@b017c000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb017c000 0x4000>;
+			clocks = <&cmu CLK_I2C3>;
+			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller
  2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
@ 2020-11-28  7:19   ` Manivannan Sadhasivam
  2020-11-28  7:34   ` Manivannan Sadhasivam
  2020-12-09 20:23   ` Wolfram Sang
  2 siblings, 0 replies; 17+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28  7:19 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Wolfram Sang, Rob Herring, Andreas Färber, linux-arm-kernel,
	linux-actions, linux-kernel, linux-i2c

On Fri, Nov 20, 2020 at 01:56:06AM +0200, Cristian Ciocaltea wrote:
> Add S500 variant to the list of devices supported by the Actions Semi
> Owl I2C driver.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Ah, I thought S500 support needs some change...

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/i2c/busses/i2c-owl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 5cf5a119a6ad..98882fe4e965 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -508,6 +508,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id owl_i2c_of_match[] = {
> +	{ .compatible = "actions,s500-i2c" },
>  	{ .compatible = "actions,s700-i2c" },
>  	{ .compatible = "actions,s900-i2c" },
>  	{ /* sentinel */ }
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller
  2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
  2020-11-28  7:19   ` Manivannan Sadhasivam
@ 2020-11-28  7:34   ` Manivannan Sadhasivam
  2020-12-09 20:23   ` Wolfram Sang
  2 siblings, 0 replies; 17+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28  7:34 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Wolfram Sang, Rob Herring, Andreas Färber, linux-arm-kernel,
	linux-actions, linux-kernel, linux-i2c

On Fri, Nov 20, 2020 at 01:56:06AM +0200, Cristian Ciocaltea wrote:
> Add S500 variant to the list of devices supported by the Actions Semi
> Owl I2C driver.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/i2c/busses/i2c-owl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c
> index 5cf5a119a6ad..98882fe4e965 100644
> --- a/drivers/i2c/busses/i2c-owl.c
> +++ b/drivers/i2c/busses/i2c-owl.c
> @@ -508,6 +508,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id owl_i2c_of_match[] = {
> +	{ .compatible = "actions,s500-i2c" },
>  	{ .compatible = "actions,s700-i2c" },
>  	{ .compatible = "actions,s900-i2c" },
>  	{ /* sentinel */ }
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support
  2020-11-19 23:56 ` [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support Cristian Ciocaltea
@ 2020-11-28  7:35   ` Manivannan Sadhasivam
  2020-12-09 20:25     ` Wolfram Sang
  0 siblings, 1 reply; 17+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-28  7:35 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Rob Herring, Wolfram Sang, Andreas Färber, devicetree,
	linux-arm-kernel, linux-actions, linux-kernel, linux-i2c

On Fri, Nov 20, 2020 at 01:56:07AM +0200, Cristian Ciocaltea wrote:
> Add I2C controller nodes for Actions Semi S500 SoC.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  arch/arm/boot/dts/owl-s500.dtsi | 40 +++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/owl-s500.dtsi b/arch/arm/boot/dts/owl-s500.dtsi
> index 7af7c9e1119d..55f8b8c2e149 100644
> --- a/arch/arm/boot/dts/owl-s500.dtsi
> +++ b/arch/arm/boot/dts/owl-s500.dtsi
> @@ -193,6 +193,46 @@ cmu: clock-controller@b0160000 {
>  			#reset-cells = <1>;
>  		};
>  
> +		i2c0: i2c@b0170000 {
> +			compatible = "actions,s500-i2c";
> +			reg = <0xb0170000 0x4000>;
> +			clocks = <&cmu CLK_I2C0>;
> +			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		i2c1: i2c@b0174000 {
> +			compatible = "actions,s500-i2c";
> +			reg = <0xb0174000 0x4000>;
> +			clocks = <&cmu CLK_I2C1>;
> +			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		i2c2: i2c@b0178000 {
> +			compatible = "actions,s500-i2c";
> +			reg = <0xb0178000 0x4000>;
> +			clocks = <&cmu CLK_I2C2>;
> +			interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
> +		i2c3: i2c@b017c000 {
> +			compatible = "actions,s500-i2c";
> +			reg = <0xb017c000 0x4000>;
> +			clocks = <&cmu CLK_I2C3>;
> +			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			status = "disabled";
> +		};
> +
>  		timer: timer@b0168000 {
>  			compatible = "actions,s500-timer";
>  			reg = <0xb0168000 0x8000>;
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs
  2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
                   ` (3 preceding siblings ...)
  2020-11-19 23:56 ` [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support Cristian Ciocaltea
@ 2020-12-05  6:11 ` Manivannan Sadhasivam
  2020-12-05 16:29   ` Cristian Ciocaltea
  4 siblings, 1 reply; 17+ messages in thread
From: Manivannan Sadhasivam @ 2020-12-05  6:11 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Rob Herring, Andreas Färber, Vinod Koul, Wolfram Sang,
	Ulf Hansson, Dan Williams, devicetree, linux-arm-kernel,
	linux-actions, linux-kernel, dmaengine, linux-i2c, linux-mmc

Hi Cristi,

On Fri, Nov 20, 2020 at 01:55:54AM +0200, Cristian Ciocaltea wrote:
> Hi,
> 
> This patchset brings a series of improvements for the Actions Semi S500
> SoCs family, by adding support for Clock & Reset Management Units, DMA,
> MMC, I2C & SIRQ controllers.
> 
> Please note the patches consist mostly of DTS and bindings/compatibles
> changes, since all the work they depend on has been already merged,
> i.e. clock fixes/additions, pinctrl driver, sirq driver.
> 
> For the moment, I have only enabled the features I could test on
> RoseapplePi SBC.
> 

I was hoping to apply this series for v5.11 but we ran out of time. So expect
this series to be in v5.12.

Thanks,
Mani

> Thanks,
> Cristi
> 
> Changes in v2:
> - Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
> - Added support for the SIRQ controller
> - Added new entries in MAINTAINERS
> - Updated naming of some patches in v1
> 
> Cristian Ciocaltea (18):
>   arm: dts: owl-s500: Add Clock Management Unit
>   arm: dts: owl-s500: Set CMU clocks for UARTs
>   arm: dts: owl-s500: Add Reset controller
>   dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
>   dmaengine: owl: Add compatible for the Actions Semi S500 DMA
>     controller
>   arm: dts: owl-s500: Add DMA controller
>   arm: dts: owl-s500: Add pinctrl & GPIO support
>   dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
>   arm: dts: owl-s500: Add MMC support
>   dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
>   MAINTAINERS: Update entry for Actions Semi Owl I2C binding
>   i2c: owl: Add compatible for the Actions Semi S500 I2C controller
>   arm: dts: owl-s500: Add I2C support
>   arm: dts: owl-s500: Add SIRQ controller
>   arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
>   arm: dts: owl-s500-roseapplepi: Add uSD support
>   arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
>   MAINTAINERS: Add linux-actions ML for Actions Semi Arch
> 
>  .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
>  .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
>  .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
>  .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
>  MAINTAINERS                                   |   3 +-
>  arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
>  arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
>  drivers/dma/owl-dma.c                         |   1 +
>  drivers/i2c/busses/i2c-owl.c                  |   1 +
>  9 files changed, 304 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> 
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs
  2020-12-05  6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
@ 2020-12-05 16:29   ` Cristian Ciocaltea
  0 siblings, 0 replies; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-12-05 16:29 UTC (permalink / raw)
  To: Manivannan Sadhasivam
  Cc: Rob Herring, Andreas Färber, Vinod Koul, Wolfram Sang,
	Ulf Hansson, Dan Williams, devicetree, linux-arm-kernel,
	linux-actions, linux-kernel, dmaengine, linux-i2c, linux-mmc

Hi Mani,

On Sat, Dec 05, 2020 at 11:41:15AM +0530, Manivannan Sadhasivam wrote:
> Hi Cristi,
> 
> On Fri, Nov 20, 2020 at 01:55:54AM +0200, Cristian Ciocaltea wrote:
> > Hi,
> > 
> > This patchset brings a series of improvements for the Actions Semi S500
> > SoCs family, by adding support for Clock & Reset Management Units, DMA,
> > MMC, I2C & SIRQ controllers.
> > 
> > Please note the patches consist mostly of DTS and bindings/compatibles
> > changes, since all the work they depend on has been already merged,
> > i.e. clock fixes/additions, pinctrl driver, sirq driver.
> > 
> > For the moment, I have only enabled the features I could test on
> > RoseapplePi SBC.
> > 
> 
> I was hoping to apply this series for v5.11 but we ran out of time. So expect
> this series to be in v5.12.

No problem, thanks a lot for taking care of this!

Kind regards,
Cristi

> Thanks,
> Mani
> 
> > Thanks,
> > Cristi
> > 
> > Changes in v2:
> > - Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
> > - Added support for the SIRQ controller
> > - Added new entries in MAINTAINERS
> > - Updated naming of some patches in v1
> > 
> > Cristian Ciocaltea (18):
> >   arm: dts: owl-s500: Add Clock Management Unit
> >   arm: dts: owl-s500: Set CMU clocks for UARTs
> >   arm: dts: owl-s500: Add Reset controller
> >   dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
> >   dmaengine: owl: Add compatible for the Actions Semi S500 DMA
> >     controller
> >   arm: dts: owl-s500: Add DMA controller
> >   arm: dts: owl-s500: Add pinctrl & GPIO support
> >   dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
> >   arm: dts: owl-s500: Add MMC support
> >   dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
> >   MAINTAINERS: Update entry for Actions Semi Owl I2C binding
> >   i2c: owl: Add compatible for the Actions Semi S500 I2C controller
> >   arm: dts: owl-s500: Add I2C support
> >   arm: dts: owl-s500: Add SIRQ controller
> >   arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
> >   arm: dts: owl-s500-roseapplepi: Add uSD support
> >   arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
> >   MAINTAINERS: Add linux-actions ML for Actions Semi Arch
> > 
> >  .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
> >  .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
> >  .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
> >  .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
> >  MAINTAINERS                                   |   3 +-
> >  arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
> >  arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
> >  drivers/dma/owl-dma.c                         |   1 +
> >  drivers/i2c/busses/i2c-owl.c                  |   1 +
> >  9 files changed, 304 insertions(+), 38 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
> >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> > 
> > -- 
> > 2.29.2
> > 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
  2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
@ 2020-12-07 22:12   ` Rob Herring
  2020-12-07 22:58     ` Cristian Ciocaltea
  2020-12-09 20:22   ` Wolfram Sang
  1 sibling, 1 reply; 17+ messages in thread
From: Rob Herring @ 2020-12-07 22:12 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Wolfram Sang, devicetree, linux-i2c, linux-actions, linux-kernel,
	Manivannan Sadhasivam, Rob Herring, Andreas Färber,
	linux-arm-kernel

On Fri, 20 Nov 2020 01:56:04 +0200, Cristian Ciocaltea wrote:
> Convert the Actions Semi Owl I2C DT binding to a YAML schema for
> enabling DT validation.
> 
> Additionally, add a new compatible string corresponding to the I2C
> controller found in the S500 variant of the Actions Semi Owl SoCs
> family.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> ---
>  .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
>  .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
>  2 files changed, 62 insertions(+), 29 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
>  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
  2020-12-07 22:12   ` Rob Herring
@ 2020-12-07 22:58     ` Cristian Ciocaltea
  0 siblings, 0 replies; 17+ messages in thread
From: Cristian Ciocaltea @ 2020-12-07 22:58 UTC (permalink / raw)
  To: Rob Herring
  Cc: Wolfram Sang, devicetree, linux-i2c, linux-actions, linux-kernel,
	Manivannan Sadhasivam, Rob Herring, Andreas Färber,
	linux-arm-kernel

On Mon, Dec 07, 2020 at 04:12:14PM -0600, Rob Herring wrote:
> On Fri, 20 Nov 2020 01:56:04 +0200, Cristian Ciocaltea wrote:
> > Convert the Actions Semi Owl I2C DT binding to a YAML schema for
> > enabling DT validation.
> > 
> > Additionally, add a new compatible string corresponding to the I2C
> > controller found in the S500 variant of the Actions Semi Owl SoCs
> > family.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > ---
> >  .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
> >  .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
> >  2 files changed, 62 insertions(+), 29 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
> >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks for reviewing,
Cristi

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
  2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
  2020-12-07 22:12   ` Rob Herring
@ 2020-12-09 20:22   ` Wolfram Sang
  1 sibling, 0 replies; 17+ messages in thread
From: Wolfram Sang @ 2020-12-09 20:22 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Rob Herring, Andreas Färber, Manivannan Sadhasivam,
	devicetree, linux-arm-kernel, linux-actions, linux-kernel,
	linux-i2c

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

On Fri, Nov 20, 2020 at 01:56:04AM +0200, Cristian Ciocaltea wrote:
> Convert the Actions Semi Owl I2C DT binding to a YAML schema for
> enabling DT validation.
> 
> Additionally, add a new compatible string corresponding to the I2C
> controller found in the S500 variant of the Actions Semi Owl SoCs
> family.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding
  2020-11-19 23:56 ` [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding Cristian Ciocaltea
@ 2020-12-09 20:22   ` Wolfram Sang
  0 siblings, 0 replies; 17+ messages in thread
From: Wolfram Sang @ 2020-12-09 20:22 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Andreas Färber, Manivannan Sadhasivam, linux-arm-kernel,
	linux-actions, linux-kernel, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

On Fri, Nov 20, 2020 at 01:56:05AM +0200, Cristian Ciocaltea wrote:
> The Actions Semi Owl I2C DT binding has been converted to YAML schema,
> therefore update accordingly the entry in MAINTAINERS.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Squashed with 10/18 and applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller
  2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
  2020-11-28  7:19   ` Manivannan Sadhasivam
  2020-11-28  7:34   ` Manivannan Sadhasivam
@ 2020-12-09 20:23   ` Wolfram Sang
  2 siblings, 0 replies; 17+ messages in thread
From: Wolfram Sang @ 2020-12-09 20:23 UTC (permalink / raw)
  To: Cristian Ciocaltea
  Cc: Rob Herring, Andreas Färber, Manivannan Sadhasivam,
	linux-arm-kernel, linux-actions, linux-kernel, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

On Fri, Nov 20, 2020 at 01:56:06AM +0200, Cristian Ciocaltea wrote:
> Add S500 variant to the list of devices supported by the Actions Semi
> Owl I2C driver.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support
  2020-11-28  7:35   ` Manivannan Sadhasivam
@ 2020-12-09 20:25     ` Wolfram Sang
  2020-12-10  3:33       ` Manivannan Sadhasivam
  0 siblings, 1 reply; 17+ messages in thread
From: Wolfram Sang @ 2020-12-09 20:25 UTC (permalink / raw)
  To: Manivannan Sadhasivam
  Cc: Cristian Ciocaltea, Rob Herring, Andreas Färber, devicetree,
	linux-arm-kernel, linux-actions, linux-kernel, linux-i2c

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

On Sat, Nov 28, 2020 at 01:05:16PM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 20, 2020 at 01:56:07AM +0200, Cristian Ciocaltea wrote:
> > Add I2C controller nodes for Actions Semi S500 SoC.
> > 
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

DTS changes usually go in via arm-soc, so I am not picking this unless
there is a reason to do so.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support
  2020-12-09 20:25     ` Wolfram Sang
@ 2020-12-10  3:33       ` Manivannan Sadhasivam
  0 siblings, 0 replies; 17+ messages in thread
From: Manivannan Sadhasivam @ 2020-12-10  3:33 UTC (permalink / raw)
  To: Wolfram Sang, Cristian Ciocaltea, Rob Herring,
	Andreas Färber, devicetree, linux-arm-kernel, linux-actions,
	linux-kernel, linux-i2c

On Wed, Dec 09, 2020 at 09:25:06PM +0100, Wolfram Sang wrote:
> On Sat, Nov 28, 2020 at 01:05:16PM +0530, Manivannan Sadhasivam wrote:
> > On Fri, Nov 20, 2020 at 01:56:07AM +0200, Cristian Ciocaltea wrote:
> > > Add I2C controller nodes for Actions Semi S500 SoC.
> > > 
> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
> > 
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> DTS changes usually go in via arm-soc, so I am not picking this unless
> there is a reason to do so.
> 

No you should not. This patch will go through actions sub tree which me or
Andreas will pick it.

Thanks,
Mani


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2020-12-10  3:34 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-19 23:55 [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Cristian Ciocaltea
2020-11-19 23:56 ` [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema Cristian Ciocaltea
2020-12-07 22:12   ` Rob Herring
2020-12-07 22:58     ` Cristian Ciocaltea
2020-12-09 20:22   ` Wolfram Sang
2020-11-19 23:56 ` [PATCH v2 11/18] MAINTAINERS: Update entry for Actions Semi Owl I2C binding Cristian Ciocaltea
2020-12-09 20:22   ` Wolfram Sang
2020-11-19 23:56 ` [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller Cristian Ciocaltea
2020-11-28  7:19   ` Manivannan Sadhasivam
2020-11-28  7:34   ` Manivannan Sadhasivam
2020-12-09 20:23   ` Wolfram Sang
2020-11-19 23:56 ` [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support Cristian Ciocaltea
2020-11-28  7:35   ` Manivannan Sadhasivam
2020-12-09 20:25     ` Wolfram Sang
2020-12-10  3:33       ` Manivannan Sadhasivam
2020-12-05  6:11 ` [PATCH v2 00/18] Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs Manivannan Sadhasivam
2020-12-05 16:29   ` Cristian Ciocaltea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).