From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F0ACC433FE for ; Thu, 10 Dec 2020 20:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A74A023406 for ; Thu, 10 Dec 2020 20:00:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404402AbgLJT7y (ORCPT ); Thu, 10 Dec 2020 14:59:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:60756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404416AbgLJT7n (ORCPT ); Thu, 10 Dec 2020 14:59:43 -0500 Date: Thu, 10 Dec 2020 20:58:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607630342; bh=s2+iLf6qBKVf58ffYZN9l2zof1I9JLW9V6wDx6uBGB8=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=eklBHcybGU7NaHOQQv++7WWXgTVIXfU4CnRYhDTvdmMh828hU1HhwGuy262A7mXl3 UVfMlgSR9hjmxiHEEmyAKdwE8N24GronEa9YX/3xByG12lhH5sLlYjOzWtARATmbU+ gbjs//eYTsEVpjwIHW5m8/FwAch5WCZ79eUruF3gO37OfRXISugUzkUxi/tczLL5H1 C81E6xkV7hUWEVha0XOmiWm7bl+CmN06kwTj6Wpcq+BBF8+02d6kP4fL05muxPEfXb pZ3KGXhlBNtOeEDWP9EZLwn/4dPMZS2smZLYs42jw9BUNf2bClh/cggGRtfKBSWABt n3IVdl/kI4rwg== From: Wolfram Sang To: Heiner Kallweit Cc: George Cherian , Herbert Xu , "David S. Miller" , Zaibo Xu , Boris Brezillon , Arnaud Ebalard , Srujana Challa , Matthias Brugger , Giovanni Cabiddu , Elie Morisse , Nehal Shah , Shyam Sundar S K , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , Andreas Larsson , Jakub Kicinski , Netanel Belgazal , Arthur Kiyanovski , Guy Tzalik , Saeed Bishara , Zorik Machulsky , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Igor Russkikh , Jay Cliburn , Chris Snook , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com, Michael Chan , Raju Rangoju , Madalin Bucur , Ioana Ciornei , Ioana Radulescu , Claudiu Manoil , Catherine Sullivan , Sagi Shahar , Jon Olson , Yisen Zhuang , Salil Mehta , Hauke Mehrtens , Sebastian Hesselbarth , Thomas Petazzoni , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Boris Pismenny , Jon Mason , Rain River , Zhu Yanjun , Shannon Nelson , Pensando Drivers , Jiri Pirko , Edward Cree , Martin Habets , Daniele Venzano , Kunihiko Hayashi , Wingman Kwok , Murali Karicheri , Kevin Brace , Radhey Shyam Pandey , Michal Simek , Kalle Valo , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Larry Finger , Luca Coelho , Lorenzo Bianconi , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, qat-linux@intel.com, linux-i2c@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core Message-ID: <20201210195855.GA11120@kunai> Mail-Followup-To: Wolfram Sang , Heiner Kallweit , George Cherian , Herbert Xu , "David S. Miller" , Zaibo Xu , Boris Brezillon , Arnaud Ebalard , Srujana Challa , Matthias Brugger , Giovanni Cabiddu , Elie Morisse , Nehal Shah , Shyam Sundar S K , Mike Marciniszyn , Dennis Dalessandro , Doug Ledford , Jason Gunthorpe , Andreas Larsson , Jakub Kicinski , Netanel Belgazal , Arthur Kiyanovski , Guy Tzalik , Saeed Bishara , Zorik Machulsky , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Igor Russkikh , Jay Cliburn , Chris Snook , Ariel Elior , Sudarsana Kalluru , GR-everest-linux-l2@marvell.com, Michael Chan , Raju Rangoju , Madalin Bucur , Ioana Ciornei , Ioana Radulescu , Claudiu Manoil , Catherine Sullivan , Sagi Shahar , Jon Olson , Yisen Zhuang , Salil Mehta , Hauke Mehrtens , Sebastian Hesselbarth , Thomas Petazzoni , Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Boris Pismenny , Jon Mason , Rain River , Zhu Yanjun , Shannon Nelson , Pensando Drivers , Jiri Pirko , Edward Cree , Martin Habets , Daniele Venzano , Kunihiko Hayashi , Wingman Kwok , Murali Karicheri , Kevin Brace , Radhey Shyam Pandey , Michal Simek , Kalle Valo , Jiri Slaby , Nick Kossifidis , Luis Chamberlain , Larry Finger , Luca Coelho , Lorenzo Bianconi , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, qat-linux@intel.com, linux-i2c@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, iommu@lists.linux-foundation.org References: <5d08af46-5897-b827-dcfb-181d869c8f71@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <5d08af46-5897-b827-dcfb-181d869c8f71@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 10, 2020 at 03:47:50PM +0100, Heiner Kallweit wrote: > Zillions of drivers use the unlikely() hint when checking the result of > dma_mapping_error(). This is an inline function anyway, so we can move > the hint into the function and remove it from drivers. > From time to time discussions pop up how effective unlikely() is, > and that it should be used only if something is really very unlikely. > I think that's the case here. >=20 > Patch was created with some help from coccinelle. >=20 > @@ > expression dev, dma_addr; > @@ >=20 > - unlikely(dma_mapping_error(dev, dma_addr)) > + dma_mapping_error(dev, dma_addr) >=20 > Signed-off-by: Heiner Kallweit Acked-by: Wolfram Sang # for I2C --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl/SffoACgkQFA3kzBSg KbYcjxAAgOE4gHcgEP8+Oex1fposdP2Z4KiWFjIYYWG4fo/Ry9PjDbSGh9Nptht2 fnsCRcFXFj4oaSXaflBTq6ky4usgo2Gyp9puXbnpyj7P2uEjrqZs1zUFpAWdzMor UgiJkW/P2IZjCDfwxE8nn9L0fm8ZfcHWqVohAgDh/9SKsrQCdzlzwvd7vSQ94fXr qnYrmc6BF68dxVZx4TV18GddP5qFXYKytQ8pXL51XZEJTI05IGmc2l6hs/B4tKj6 muxiEFw5Ac0eseMimi4J5YDJJZxWe28onn69mMJYQDzVPqSZRyhSAqCv0EhMg6Vp sABbG/eShtxir8A5ZrVRgqCaVyBjPu6pHAxdccHkj4d/6hfvD6F2FDXXaWirAf3i A4gsMJAmxtBYV0Lyx0D+fzCFnvUSDDSOEayRJdzotQXVCbLvuWHTp6EXVJFD5mMU /o3LApTC1uYQTXfGh1HHanpSEXLXfVgzjuDHRUsVIwemk5JwUAl6fw4oXbMrHYdZ v9Inx4U81LGxayz1vGmzbE39AeE7YH/5lH4metjot96RpKa+Gg++mMxUHBPW6Jam AOz6I3cKYsn7mPkzAZfDNvhvfgz2vxXcGGULSCdaWnVCJY7FMqe8i98w1z/Ymo7U JSXmDUhFS43r0JqUfbR0sRGgLL+kHTEa6I4ZT8UNd9DmTtS0Jmo= =4X1P -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--