From: Wolfram Sang <wsa@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-i2c@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 1/2] i2c: Warn when device removing fails
Date: Fri, 11 Dec 2020 15:00:53 +0100 [thread overview]
Message-ID: <20201211140053.GA2755@kunai> (raw)
In-Reply-To: <20201211104328.3h5of6kegwcbhob2@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Hi Uwe,
> Yes, I'm not paid for it, but it serves as an idle cleanup task for me.
You have idle time? ;)
> > No need to initialize to 0, or?
>
> Right, this comes straight from:
> - int status = 0;
>
> from the current version of i2c_device_remove, where it was still
> relevant. I don't feel strong here, and if you do I can resend or you
> can fixup while applying.
I will fix it. Also, I will add a comment mentioning this as cleanup
preparation.
Thanks and have a nice weekend!
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-11 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 7:23 [PATCH 1/2] i2c: Warn when device removing fails Uwe Kleine-König
2020-11-26 7:23 ` [PATCH 2/2] i2c: remove check that can never be true Uwe Kleine-König
2020-12-11 14:44 ` Wolfram Sang
2020-12-10 20:10 ` [PATCH 1/2] i2c: Warn when device removing fails Wolfram Sang
2020-12-11 10:43 ` Uwe Kleine-König
2020-12-11 14:00 ` Wolfram Sang [this message]
2020-12-11 14:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211140053.GA2755@kunai \
--to=wsa@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).