From: Wolfram Sang <wsa@the-dreams.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy@infradead.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] i2c: core: Do not print duplicate error when failing to register an i2c-client from ACPI
Date: Tue, 5 Jan 2021 11:00:01 +0100 [thread overview]
Message-ID: <20210105100001.GB2000@ninjato> (raw)
In-Reply-To: <20201221191300.244648-1-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
On Mon, Dec 21, 2020 at 08:13:00PM +0100, Hans de Goede wrote:
> i2c_new_client_device() already prints an error when it fails. Some
> ACPI tables contain 2 ACPI devices describing the same i2c-client,
> leading to errors like this:
>
> [ 1.620847] i2c i2c-4: Failed to register i2c client MAGN0001:00 at 0x1d (-16)
> [ 1.620870] i2c i2c-4: failed to add I2C device MAGN0001:00 from ACPI
>
> There is nothing we can do about the first -EBUSY error being logged,
> but the second error does not really add any new information, so lets
> drop it.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-01-05 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 19:13 [PATCH] i2c: core: Do not print duplicate error when failing to register an i2c-client from ACPI Hans de Goede
2020-12-21 19:24 ` Andy Shevchenko
2020-12-22 9:18 ` Mika Westerberg
2021-01-05 10:00 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105100001.GB2000@ninjato \
--to=wsa@the-dreams.de \
--cc=andy@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).