From: Wolfram Sang <wsa@kernel.org>
To: trix@redhat.com, Jean Delvare <jdelvare@suse.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: remove h from printk format specifier
Date: Tue, 5 Jan 2021 11:09:42 +0100 [thread overview]
Message-ID: <20210105100942.GC2000@ninjato> (raw)
In-Reply-To: <20201215183327.2072052-1-trix@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Tue, Dec 15, 2020 at 10:33:27AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Adding Jean to CC. Jean, I'd think %02x would be better, what do you
think?
> ---
> drivers/i2c/i2c-smbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
> index d3d06e3b4f3b..5cd2cf84659e 100644
> --- a/drivers/i2c/i2c-smbus.c
> +++ b/drivers/i2c/i2c-smbus.c
> @@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
>
> if (!IS_ERR(i2c_new_scanned_device(adap, &info, addr_list, NULL))) {
> dev_info(&adap->dev,
> - "Successfully instantiated SPD at 0x%hx\n",
> + "Successfully instantiated SPD at 0x%x\n",
> addr_list[0]);
> dimm_count--;
> }
> --
> 2.27.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-05 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 18:33 [PATCH] i2c: remove h from printk format specifier trix
2021-01-05 10:09 ` Wolfram Sang [this message]
2021-01-06 14:43 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105100942.GC2000@ninjato \
--to=wsa@kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).