* [PATCH] i2c: remove h from printk format specifier
@ 2020-12-15 18:33 trix
2021-01-05 10:09 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: trix @ 2020-12-15 18:33 UTC (permalink / raw)
To: wsa; +Cc: linux-i2c, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/i2c/i2c-smbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
index d3d06e3b4f3b..5cd2cf84659e 100644
--- a/drivers/i2c/i2c-smbus.c
+++ b/drivers/i2c/i2c-smbus.c
@@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
if (!IS_ERR(i2c_new_scanned_device(adap, &info, addr_list, NULL))) {
dev_info(&adap->dev,
- "Successfully instantiated SPD at 0x%hx\n",
+ "Successfully instantiated SPD at 0x%x\n",
addr_list[0]);
dimm_count--;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: remove h from printk format specifier
2020-12-15 18:33 [PATCH] i2c: remove h from printk format specifier trix
@ 2021-01-05 10:09 ` Wolfram Sang
2021-01-06 14:43 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2021-01-05 10:09 UTC (permalink / raw)
To: trix, Jean Delvare; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
On Tue, Dec 15, 2020 at 10:33:27AM -0800, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Adding Jean to CC. Jean, I'd think %02x would be better, what do you
think?
> ---
> drivers/i2c/i2c-smbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
> index d3d06e3b4f3b..5cd2cf84659e 100644
> --- a/drivers/i2c/i2c-smbus.c
> +++ b/drivers/i2c/i2c-smbus.c
> @@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
>
> if (!IS_ERR(i2c_new_scanned_device(adap, &info, addr_list, NULL))) {
> dev_info(&adap->dev,
> - "Successfully instantiated SPD at 0x%hx\n",
> + "Successfully instantiated SPD at 0x%x\n",
> addr_list[0]);
> dimm_count--;
> }
> --
> 2.27.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: remove h from printk format specifier
2021-01-05 10:09 ` Wolfram Sang
@ 2021-01-06 14:43 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2021-01-06 14:43 UTC (permalink / raw)
To: Wolfram Sang; +Cc: trix, linux-i2c, linux-kernel
Hi Tom, Wolfram,
On Tue, 5 Jan 2021 11:09:42 +0100, Wolfram Sang wrote:
> On Tue, Dec 15, 2020 at 10:33:27AM -0800, trix@redhat.com wrote:
> > From: Tom Rix <trix@redhat.com>
> >
> > See Documentation/core-api/printk-formats.rst.
> > h should no longer be used in the format specifier for printk.
> >
> > Signed-off-by: Tom Rix <trix@redhat.com>
>
> Adding Jean to CC. Jean, I'd think %02x would be better, what do you
> think?
Agreed, 0x%02x would be better.
If this is done then you can add:
Reviewed-by: Jean Delvare <jdelvare@suse.de>
> > ---
> > drivers/i2c/i2c-smbus.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
> > index d3d06e3b4f3b..5cd2cf84659e 100644
> > --- a/drivers/i2c/i2c-smbus.c
> > +++ b/drivers/i2c/i2c-smbus.c
> > @@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)
> >
> > if (!IS_ERR(i2c_new_scanned_device(adap, &info, addr_list, NULL))) {
> > dev_info(&adap->dev,
> > - "Successfully instantiated SPD at 0x%hx\n",
> > + "Successfully instantiated SPD at 0x%x\n",
> > addr_list[0]);
> > dimm_count--;
> > }
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-06 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-15 18:33 [PATCH] i2c: remove h from printk format specifier trix
2021-01-05 10:09 ` Wolfram Sang
2021-01-06 14:43 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).