From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Robert Richter <rric@kernel.org>,
Jan Glauber <jan.glauber@gmail.com>,
David Daney <david.daney@cavium.com>,
Wolfram Sang <wsa@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] i2c: octeon: check correct size of maximum RECV_LEN packet
Date: Sat, 9 Jan 2021 13:43:08 +0100 [thread overview]
Message-ID: <20210109124314.27466-5-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20210109124314.27466-1-wsa+renesas@sang-engineering.com>
I2C_SMBUS_BLOCK_MAX defines already the maximum number as defined in the
SMBus 2.0 specs. No reason to add one to it.
Fixes: 886f6f8337dd ("i2c: octeon: Support I2C_M_RECV_LEN")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-octeon-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-octeon-core.c b/drivers/i2c/busses/i2c-octeon-core.c
index d9607905dc2f..845eda70b8ca 100644
--- a/drivers/i2c/busses/i2c-octeon-core.c
+++ b/drivers/i2c/busses/i2c-octeon-core.c
@@ -347,7 +347,7 @@ static int octeon_i2c_read(struct octeon_i2c *i2c, int target,
if (result)
return result;
if (recv_len && i == 0) {
- if (data[i] > I2C_SMBUS_BLOCK_MAX + 1)
+ if (data[i] > I2C_SMBUS_BLOCK_MAX)
return -EPROTO;
length += data[i];
}
--
2.29.2
next prev parent reply other threads:[~2021-01-09 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 12:43 [PATCH 0/8] i2c: improve RECV_LEN documentation & usage Wolfram Sang
2021-01-09 12:43 ` [PATCH 1/8] i2c: refactor documentation of struct i2c_msg Wolfram Sang
2021-01-09 12:43 ` [PATCH 2/8] i2c: remove licence boilerplate from main UAPI header Wolfram Sang
2021-01-09 12:43 ` [PATCH 3/8] i2c: remove licence boilerplate from i2c-dev " Wolfram Sang
2021-01-09 12:43 ` Wolfram Sang [this message]
2021-01-11 9:26 ` [PATCH 4/8] i2c: octeon: check correct size of maximum RECV_LEN packet Robert Richter
2021-01-17 11:27 ` Wolfram Sang
2021-01-09 12:43 ` [PATCH 5/8] i2c: uapi: add macro to describe support for all SMBus transfers Wolfram Sang
2021-01-09 12:43 ` [PATCH 6/8] i2c: algo: bit: use new macro to specifiy capabilities Wolfram Sang
2021-01-09 12:43 ` [PATCH 7/8] i2c: qup: advertise SMBus transfers using RECV_LEN Wolfram Sang
2021-01-09 12:43 ` [PATCH 8/8] i2c: s3c2410: " Wolfram Sang
2021-01-22 9:02 ` [PATCH 0/8] i2c: improve RECV_LEN documentation & usage Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210109124314.27466-5-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=david.daney@cavium.com \
--cc=jan.glauber@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).