Re: [PATCH 1/7] soc: qcom: geni: move GENI_IF_DISABLE_RO to common header

Bjorn Andersson
2021-01-11T15:32:14Z

On Mon 11 Jan 09:16 CST 2021, Vinod Koul wrote:

> GENI_IF_DISABLE_RO is used by geni spi driver as well to check the
> status if GENI, so move this to common header qcom-geni-se.h
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/soc/qcom/qcom-geni-se.c | 1 -
> include/linux/qcom-geni-se.h | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index f42954e2c98e..285ed86c2bab 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -108,7 +108,6 @@ static struct geni_wrapper *earlycon_wrapper;
> #define GENI_OUTPUT_CTRL 0x24
> #define GENI_CGC_CTRL 0x28
> #define GENI_CLK_CTRL_RO 0x60
> -#define GENI_IF_DISABLE_RO 0x64
> #define GENI_FW_S_REVISION_RO 0x6c
> #define SE_GENI_BYTE_GRAN 0x254
> #define SE_GENI_TX_PACKING_CFG0 0x260
> diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h
> index ec2ad4b0fe14..e3f4b16040d9 100644
> --- a/include/linux/qcom-geni-se.h
> +++ b/include/linux/qcom-geni-se.h
> @@ -65,6 +65,7 @@ struct geni_se {
> #define SE_GENI_STATUS 0x40
> #define GENI_SER_M_CLK_CFG 0x48
> #define GENI_SER_S_CLK_CFG 0x4c
> +#define GENI_IF_DISABLE_RO 0x64
> #define GENI_FW_REVISION_RO 0x68
> #define SE_GENI_CLK_SEL 0x7c
> #define SE_GENI_DMA_MODE_EN 0x258
> --
> 2.26.2
>