Re: [PATCH 6/7] arm64: dts: qcom: sdm845: Add gpi dma node

Vinod Koul
2021-01-12T04:22:22Z

On 11-01-21, 12:23, Bjorn Andersson wrote:
> On Mon 11 Jan 09:16 CST 2021, Vinod Koul wrote:
>
> > This add the device node for gpi dma0 instances found in sdm845.
>
> I think the 0 in "dma0" should go?

oops, will update

>
> Apart from that, this looks good.
>
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 46 ++++++++++++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index bcf888381f14..c9a127bbd606 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -1114,6 +1114,29 @@ opp-128000000 {
> > };
> > };
> >
> > + gpi_dma0: dma-controller@800000 {
> > + #dma-cells = <3>;
>
> Nit. I know #dma-cells are important to you ;) but I would prefer to
> have the standard properties (e.g. compatible) first.

Yes will reorder
--
~Vinod