From: Wolfram Sang <wsa@kernel.org>
To: Richard Neumann <mail@richard-neumann.de>
Cc: syniurge@gmail.com, nehal-bakulchandra.shah@amd.com,
shyam-sundar.s-k@amd.com, andriy.shevchenko@linux.intel.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] i2c: i2c-amd-mp2: Remove NIH logging functions
Date: Mon, 1 Feb 2021 23:03:11 +0100 [thread overview]
Message-ID: <20210201220311.GD24315@kunai> (raw)
In-Reply-To: <20210201175138.8986-2-mail@richard-neumann.de>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Mon, Feb 01, 2021 at 06:51:37PM +0100, Richard Neumann wrote:
> Use pci_{info,warn,err,dbg} functions of the kernel's PCI API.
> Remove unnecessary ndev_pdev(), ndev_name() and ndev_dev() macros.
> While at it, remove useless __func__ from logging.
>
> Signed-off-by: Richard Neumann <mail@richard-neumann.de>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
$subject looked wrong to me so I changed it to "convert to PCI logging
functions". Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-01 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 17:51 [PATCH v3 0/2] i2c: i2c-amd-mp2: Clean up driver Richard Neumann
2021-02-01 17:51 ` [PATCH v3 1/2] i2c: i2c-amd-mp2: Remove NIH logging functions Richard Neumann
2021-02-01 18:16 ` Andy Shevchenko
2021-02-01 22:03 ` Wolfram Sang [this message]
2021-02-01 17:51 ` [PATCH v3 2/2] i2c: i2c-amd-mp2: Remove unused macro Richard Neumann
2021-02-01 22:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201220311.GD24315@kunai \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@richard-neumann.de \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=syniurge@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).