Re: [PATCH v2 1/4] PCI: Introduce pcim_alloc_irq_vectors()

Andy Shevchenko
2021-02-16T14:42:12Z

On Tue, Feb 16, 2021 at 10:18:07PM +0800, Dejin Zheng wrote:
> Introduce pcim_alloc_irq_vectors(), a device-managed version of
> pci_alloc_irq_vectors(). Introducing this function can simplify
> the error handling path in many drivers.

> - if (dev->msi_enabled)
> - pci_disable_msi(dev);
> - if (dev->msix_enabled)
> - pci_disable_msix(dev);
> + pci_free_irq_vectors(dev);

This change deserves a line in the commit message.

--
With Best Regards,
Andy Shevchenko