From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marten Lindahl <martenli@axis.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com
Subject: Re: [PATCH] i2c: exynos5: Preserve high speed master code
Date: Wed, 17 Feb 2021 09:07:47 +0100 [thread overview]
Message-ID: <20210217080747.a7nqzbotszwlb3dd@kozik-lap> (raw)
In-Reply-To: <20210216220933.2wzmft72bhjptzl3@axis.com>
On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote:
> > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more
> > expensive IO read? It's quite important because your current code will
> > bitwise-or old I2C slave address with a new one... This should break
> > during tests with multiple I2C slave devices, shouldn't it?
> >
>
> You are correct. It is better to use the macro instead, and yes,
> safer too. I only have one device that supports high speed i2c, but
> I get your point. It could potentially break.
>
> > On which HW did you test it?
>
> I used an Artpec development board as master and INA230EVM board
> as slave.
Artpec development board with? What SoC?
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-02-17 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 19:03 [PATCH] i2c: exynos5: Preserve high speed master code Mårten Lindahl
2021-02-16 7:51 ` Krzysztof Kozlowski
2021-02-16 22:09 ` Marten Lindahl
2021-02-17 8:07 ` Krzysztof Kozlowski [this message]
2021-02-17 8:32 ` Jesper Nilsson
2021-02-17 8:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217080747.a7nqzbotszwlb3dd@kozik-lap \
--to=krzk@kernel.org \
--cc=kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martenli@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox