From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD8C4C433DB for ; Sat, 27 Feb 2021 10:01:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70E9964EC4 for ; Sat, 27 Feb 2021 10:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230142AbhB0KAv (ORCPT ); Sat, 27 Feb 2021 05:00:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:47898 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbhB0KAr (ORCPT ); Sat, 27 Feb 2021 05:00:47 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 73861AAC5; Sat, 27 Feb 2021 10:00:04 +0000 (UTC) Date: Sat, 27 Feb 2021 11:00:01 +0100 From: Jean Delvare To: zuoqilin1@163.com Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, zuoqilin Subject: Re: [PATCH] i2c/busses: fix spellint typo Message-ID: <20210227110001.63579295@endymion> In-Reply-To: <20210225115338.1331-1-zuoqilin1@163.com> References: <20210225115338.1331-1-zuoqilin1@163.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi zuoqilin, There's an obvious typo in the subject. Which is kind of ironical considering the point of your patch. Also, your patch is driver-specific, so "i2c/busses:" isn't an appropriate prefix. According to the standard practice for the i2c subsystem, the proper prefix for the subject would be: "i2c: sis630:". On Thu, 25 Feb 2021 19:53:38 +0800, zuoqilin1@163.com wrote: > From: zuoqilin > > change 'adress' to 'address' Please start your sentences with a capital and end them with a dot. > > Signed-off-by: zuoqilin > --- > drivers/i2c/busses/i2c-sis630.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c > index cfb8e04..87d5625 100644 > --- a/drivers/i2c/busses/i2c-sis630.c > +++ b/drivers/i2c/busses/i2c-sis630.c > @@ -97,7 +97,7 @@ > module_param(force, bool, 0); > MODULE_PARM_DESC(force, "Forcibly enable the SIS630. DANGEROUS!"); > > -/* SMBus base adress */ > +/* SMBus base address */ > static unsigned short smbus_base; > > /* supported chips */ Other than that, the change looks OK, thanks. -- Jean Delvare SUSE L3 Support