From: Wolfram Sang <wsa@kernel.org>
To: syzbot <syzbot+ffb0b3ffa6cfbc7d7b3f@syzkaller.appspotmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in __i2c_transfer
Date: Fri, 12 Mar 2021 10:13:55 +0100 [thread overview]
Message-ID: <20210312091345.GA5294@ninjato> (raw)
In-Reply-To: <000000000000f564d305bd521b83@google.com>
[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]
On Thu, Mar 11, 2021 at 11:47:17PM -0800, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 28806e4d Merge tag 'media/v5.12-2' of git://git.kernel.org..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=11192342d00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=6bcf96204c1b8e77
> dashboard link: https://syzkaller.appspot.com/bug?extid=ffb0b3ffa6cfbc7d7b3f
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1083223ad00000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14345f0ad00000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+ffb0b3ffa6cfbc7d7b3f@syzkaller.appspotmail.com
>
> ------------[ cut here ]------------
> WARNING: CPU: 1 PID: 8406 at drivers/i2c/i2c-core-base.c:2021 __i2c_transfer+0xa87/0x17d0 drivers/i2c/i2c-core-base.c:2021
Yes, it can be argued that userspace should not be able to trigger a
WARNING. For in-kernel users, the WARN is really helpful, though. I will
add sanity checks much earlier to i2c-dev.c which will not be that
noisy.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-03-12 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 7:47 [syzbot] WARNING in __i2c_transfer syzbot
2021-03-12 9:13 ` Wolfram Sang [this message]
2021-03-12 10:09 ` syzbot
2021-03-12 11:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312091345.GA5294@ninjato \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+ffb0b3ffa6cfbc7d7b3f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).